Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: appengine/findit/crash/findit_for_client.py

Issue 2322133002: [Findit] Add cracas_crash_analysis (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/findit_for_client.py
diff --git a/appengine/findit/crash/findit_for_client.py b/appengine/findit/crash/findit_for_client.py
index e52a5cef271e461d0997a707f6b6e5801f508caa..d3c6593238c545616cf2f64cb5a3654f9a2358e8 100644
--- a/appengine/findit/crash/findit_for_client.py
+++ b/appengine/findit/crash/findit_for_client.py
@@ -21,6 +21,7 @@ from crash.type_enums import CrashClient
from model import analysis_status
from model.crash.crash_config import CrashConfig
from model.crash.fracas_crash_analysis import FracasCrashAnalysis
+from model.crash.cracas_crash_analysis import CracasCrashAnalysis
_FINDIT_FRACAS_FEEDBACK_URL_TEMPLATE = '%s/crash/fracas-result-feedback?key=%s'
@@ -71,8 +72,7 @@ def GetAnalysisForClient(crash_identifiers, client_id):
if client_id == CrashClient.FRACAS:
analysis = FracasCrashAnalysis.Get(crash_identifiers)
elif client_id == CrashClient.CRACAS: # pragma: no cover.
- # TODO(katesonia): Add CracasCrashAnalysis model.
- pass
+ analysis = CracasCrashAnalysis.Get(crash_identifiers)
elif client_id == CrashClient.CLUSTERFUZZ: # pragma: no cover.
# TODO(katesonia): Add ClusterfuzzCrashAnalysis model.
pass
@@ -88,8 +88,7 @@ def ResetAnalysis(analysis, crash_identifiers, chrome_version, signature,
if client_id == CrashClient.FRACAS:
analysis = FracasCrashAnalysis.Create(crash_identifiers)
elif client_id == CrashClient.CRACAS: # pragma: no cover.
- # TODO(katesonia): define CracasCrashAnalysis.
- return False
+ analysis = CracasCrashAnalysis.Create(crash_identifiers)
elif client_id == CrashClient.CLUSTERFUZZ: # pragma: no cover.
# TODO(katesonia): define ClusterfuzzCrashAnalysis.
return False

Powered by Google App Engine
This is Rietveld 408576698