[Findit] Add cracas_crash_analysis

appengine/findit/model/crash/test/chrome_crash_analysis_test.py

Index: appengine/findit/model/crash/test/chrome_crash_analysis_test.py
diff --git a/appengine/findit/model/crash/test/fracas_crash_analysis_test.py b/appengine/findit/model/crash/test/chrome_crash_analysis_test.py
similarity index 58%
copy from appengine/findit/model/crash/test/fracas_crash_analysis_test.py
copy to appengine/findit/model/crash/test/chrome_crash_analysis_test.py
index d87e681cbb201874ade389120c906bd8f96dad6f..7019788b92ae3fde44a98c9e0f4547a3ea45d572 100644
--- a/appengine/findit/model/crash/test/fracas_crash_analysis_test.py
+++ b/appengine/findit/model/crash/test/chrome_crash_analysis_test.py
@@ -3,14 +3,26 @@
 # found in the LICENSE file.
 
 from datetime import datetime
+import hashlib
+import json
+
+from google.appengine.ext import ndb
 
 from crash.test.crash_testcase import CrashTestCase
 from model import analysis_status
 from model import result_status
-from model.crash.fracas_crash_analysis import FracasCrashAnalysis
+from model.crash.chrome_crash_analysis import ChromeCrashAnalysis
+
+
+class _TestChromeCrashAnalysis(ChromeCrashAnalysis):

[wrengr (wrong one), 2016/09/10 00:22:06]

docstring for what this class is up to?

[stgao, 2016/09/13 17:04:47]

The name is a bit confusing. Is it just to subclass ChromeCrashAnalaysis for
testing purpose?

[Sharu Jiang, 2016/09/14 20:46:36]

Yes, this is only for testing purpose, because the ChromeCrashAnalysis is an
interface.

[Sharu Jiang, 2016/09/14 20:46:36]

Done.

+
+  @staticmethod
+  def _CreateKey(crash_identifiers):
+    return ndb.Key('_TestChromeCrashAnalysis', hashlib.sha1(
+        json.dumps(crash_identifiers, sort_keys=True)).hexdigest())
 
 
-class FracasCrashAnalysisTest(CrashTestCase):
+class ChromeCrashAnalysisTest(CrashTestCase):
 
   def testDoNotUseIdentifiersToSetProperties(self):
     crash_identifiers = {
@@ -20,15 +32,15 @@ class FracasCrashAnalysisTest(CrashTestCase):
       'platform': 'win',
       'process_type': 'browser',
     }
-    FracasCrashAnalysis.Create(crash_identifiers).put()
-    analysis = FracasCrashAnalysis.Get(crash_identifiers)
+    _TestChromeCrashAnalysis.Create(crash_identifiers).put()
+    analysis = _TestChromeCrashAnalysis.Get(crash_identifiers)
     self.assertIsNone(analysis.crashed_version)
     self.assertIsNone(analysis.signature)
     self.assertIsNone(analysis.channel)
     self.assertIsNone(analysis.platform)
 
-  def testFracasCrashAnalysisReset(self):
-    analysis = FracasCrashAnalysis()
+  def testChromeCrashAnalysisReset(self):
+    analysis = ChromeCrashAnalysis()
     analysis.historical_metadata = {}
     analysis.Reset()
     self.assertIsNone(analysis.channel)