appengine/findit/model/crash/cracas_crash_analysis.py - Issue 2322133002: [Findit] Add cracas_crash_analysis

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/model/crash/cracas_crash_analysis.py

Issue 2322133002: [Findit] Add cracas_crash_analysis (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import hashlib

	6 import json

	7

	8 from google.appengine.ext import ndb

	9

	10 from model.crash.fracas_crash_analysis import FracasCrashAnalysis

	11

	12

	13 class CracasCrashAnalysis(FracasCrashAnalysis):
	Martin Barbella 2016/09/08 21:15:39 This doesn't seem clean to me, and I suspect even This doesn't seem clean to me, and I suspect even ClusterFuzz will look very similar. Could you create a base class for these, and have the rest inherit from it? Doing so may not even be necessary if we simply include the client in the model and index on it. Sharu Jiang 2016/09/08 22:18:52 We already have a base class - CrashAnalysis, the Show quoted text On 2016/09/08 21:15:39, Martin Barbella wrote: > This doesn't seem clean to me, and I suspect even ClusterFuzz will look very > similar. Could you create a base class for these, and have the rest inherit from > it? Doing so may not even be necessary if we simply include the client in the > model and index on it. We already have a base class - CrashAnalysis, the inherited FracasCrashAnalysis will only add historical_metadata and channel fields (data in customized_data), since CracasCrashAnalysis will also add these two, so I choose make a copy here (I do need to overwrite one method though, this would be included in the next patch.), if duplicating code in FracasCrashAnalysis would seem more clear, I can do that too.
	14 """Represents an analysis of a Chrome crash."""

	15 # TODO(katesonia): Deprecate FracasCrashAnalysis after switching from Fracas

	16 # to Cracas.

	17 pass

OLD	NEW

« no previous file with comments | « appengine/findit/crash/findit_for_client.py ('k') | no next file » | no next file with comments »