Turn off the old compositing path for SPv2.

Turn off the old compositing path for SPv2.

Instead, put a PaintController on the root FrameView and paint into it with the
"classic" non-composited path.

BUG=646188
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9ed93e1cc02c566bed3569ab29f1252d6c209727
Cr-Commit-Position: refs/heads/master@{#419354}

[chrishtr, 2016-09-09 23:33:06]

Description was changed from

==========
none

BUG=
==========

to

==========
Turn off the old compositing path for SPv2.
==========

[chrishtr, 2016-09-12 23:35:18]

Description was changed from

==========
Turn off the old compositing path for SPv2.
==========

to

==========
Turn off the old compositing path for SPv2.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-09-14 00:17:36]

Description was changed from

==========
Turn off the old compositing path for SPv2.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Turn off the old compositing path for SPv2.

Instead, put a PaintController on the root FrameView and paint into it with the
"classic" non-composited path.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-09-14 00:17:47]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[chrishtr, 2016-09-14 00:17:57]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 00:18:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 00:21:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:21:55]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-09-14 00:35:53]

Please rebase this and test if it causes any regressions of
slimmingPaintInvalidation on SPv1:

run-webkit-tests
--additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation
paint/invalidation

It is good if the run gets crashes<=2 and failures<=151 (or 99 if
https://codereview.chromium.org/2332353003/ is landed).

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:211:
DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
We still need CompositingUpdate for slimmingPaintInvalidation on SPv1.

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:214:
DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
Ditto.

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2640: if
(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
slimmingPaintV2Enabled()

[chrishtr, 2016-09-14 16:34:53]

On 2016/09/14 at 00:35:53, wangxianzhu wrote:
> Please rebase this and test if it causes any regressions of
slimmingPaintInvalidation on SPv1:
> 
> run-webkit-tests
--additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation
paint/invalidation
> 
> It is good if the run gets crashes<=2 and failures<=151 (or 99 if
https://codereview.chromium.org/2332353003/ is landed).\

2 crashes, 99 failures. \o/

> 
>
https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp (right):
> 
>
https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:211:
DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
> We still need CompositingUpdate for slimmingPaintInvalidation on SPv1.
> 
>
https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:214:
DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
> Ditto.
> 
>
https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/frame/FrameView.cpp (right):
> 
>
https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/frame/FrameView.cpp:2640: if
(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
> slimmingPaintV2Enabled()

[chrishtr, 2016-09-14 16:36:03]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 16:36:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-14 16:40:22]

lgtm

[chrishtr, 2016-09-14 16:52:16]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-09-14 17:00:03]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-14 17:00:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322073006/#ps120001
(title: "none")

[commit-bot: I haz the power, 2016-09-14 17:00:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-09-14 17:00:29]

Description was changed from

==========
Turn off the old compositing path for SPv2.

Instead, put a PaintController on the root FrameView and paint into it with the
"classic" non-composited path.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Turn off the old compositing path for SPv2.

Instead, put a PaintController on the root FrameView and paint into it with the
"classic" non-composited path.

BUG=646188

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-14 17:44:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 17:44:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-09-14 19:43:23]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2016-09-14 19:43:25]

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:211:
DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
On 2016/09/14 at 00:35:53, Xianzhu wrote:
> We still need CompositingUpdate for slimmingPaintInvalidation on SPv1.

Fixed.

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:214:
DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
On 2016/09/14 at 00:35:53, Xianzhu wrote:
> Ditto.

Fixed.

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2322073006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2640: if
(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
On 2016/09/14 at 00:35:53, Xianzhu wrote:
> slimmingPaintV2Enabled()

Done.

[chrishtr, 2016-09-14 21:12:48]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-14 21:12:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322073006/#ps160001
(title: "none")

[commit-bot: I haz the power, 2016-09-14 21:13:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 21:17:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 21:17:29]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[chrishtr, 2016-09-14 23:16:52]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-09-14 23:17:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 23:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 23:21:20]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-09-15 00:33:37]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:34:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 00:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:39:22]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-09-15 17:15:59]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-15 17:16:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322073006/#ps180001
(title: "none")

[commit-bot: I haz the power, 2016-09-15 17:16:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 18:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:06:57]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-09-15 19:13:24]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-15 19:13:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322073006/#ps200001
(title: "none")

[commit-bot: I haz the power, 2016-09-15 19:13:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 20:25:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 20:25:35]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[chrishtr, 2016-09-15 20:44:36]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-15 20:44:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322073006/#ps220001
(title: "none")

[commit-bot: I haz the power, 2016-09-15 20:45:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 22:10:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:10:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2016-09-15 22:12:23]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:12:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 23:15:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 23:15:41]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chrishtr, 2016-09-16 00:28:24]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-16 00:28:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322073006/#ps260001
(title: "none")

[commit-bot: I haz the power, 2016-09-16 00:29:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 01:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 01:42:06]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-09-16 14:02:36]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-16 14:02:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322073006/#ps280001
(title: "none")

[commit-bot: I haz the power, 2016-09-16 14:02:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 15:28:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 15:28:49]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chrishtr, 2016-09-16 15:45:17]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-09-16 15:45:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 17:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 17:11:50]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chrishtr, 2016-09-16 20:54:44]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-16 20:54:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322073006/#ps300001
(title: "none")

[commit-bot: I haz the power, 2016-09-16 20:55:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 21:54:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 21:54:08]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chrishtr, 2016-09-16 23:31:13]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-16 23:31:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322073006/#ps340001
(title: "none")

[commit-bot: I haz the power, 2016-09-16 23:32:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 01:01:34]

Committed patchset #18 (id:340001)

[commit-bot: I haz the power, 2016-09-17 01:02:56]

Description was changed from

==========
Turn off the old compositing path for SPv2.

Instead, put a PaintController on the root FrameView and paint into it with the
"classic" non-composited path.

BUG=646188

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Turn off the old compositing path for SPv2.

Instead, put a PaintController on the root FrameView and paint into it with the
"classic" non-composited path.

BUG=646188

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9ed93e1cc02c566bed3569ab29f1252d6c209727
Cr-Commit-Position: refs/heads/master@{#419354}
==========

[commit-bot: I haz the power, 2016-09-17 01:02:58]

Patchset 18 (id:??) landed as
https://crrev.com/9ed93e1cc02c566bed3569ab29f1252d6c209727
Cr-Commit-Position: refs/heads/master@{#419354}

[pdr., 2016-09-21 20:56:32]

https://codereview.chromium.org/2322073006/diff/340001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/FramePainter.cpp (right):

https://codereview.chromium.org/2322073006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/FramePainter.cpp:53: if
(frameView().frame().isLocalRoot()) {
Why was this needed?

[chrishtr, 2016-09-21 21:08:50]

https://codereview.chromium.org/2322073006/diff/340001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/FramePainter.cpp (right):

https://codereview.chromium.org/2322073006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/FramePainter.cpp:53: if
(frameView().frame().isLocalRoot()) {
On 2016/09/21 at 20:56:31, pdr. wrote:
> Why was this needed?

Without this, it could be that painting occurred outside of an effect
(subsequence markers for
the root PaintLayer of the page). I added this to ensure that state.