Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2322073002: Add automation scripts for the new pointer event touch action wpl tests. (Closed)

Created:
4 years, 3 months ago by dtapuska
Modified:
4 years, 3 months ago
Reviewers:
Navid Zolghadr
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add automation scripts for the new pointer event touch action wpl tests. BUG=626101 Committed: https://crrev.com/9947e60b6974b7be66ed932b7f2f64f7067f5ae3 Cr-Commit-Position: refs/heads/master@{#417406}

Patch Set 1 #

Patch Set 2 : Whoops remove dead code #

Total comments: 2

Patch Set 3 : Change formatting #

Messages

Total messages: 15 (9 generated)
dtapuska
PTAL
4 years, 3 months ago (2016-09-08 19:43:22 UTC) #3
Navid Zolghadr
lgtm https://codereview.chromium.org/2322073002/diff/20001/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-down-css_touch-manual-automation.js File third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-down-css_touch-manual-automation.js (right): https://codereview.chromium.org/2322073002/diff/20001/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-down-css_touch-manual-automation.js#newcode6 third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-down-css_touch-manual-automation.js:6: return touchScrollInTarget('#target0', 'down'); Is there any difference if ...
4 years, 3 months ago (2016-09-08 19:49:20 UTC) #4
dtapuska
https://codereview.chromium.org/2322073002/diff/20001/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-down-css_touch-manual-automation.js File third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-down-css_touch-manual-automation.js (right): https://codereview.chromium.org/2322073002/diff/20001/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-down-css_touch-manual-automation.js#newcode6 third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-down-css_touch-manual-automation.js:6: return touchScrollInTarget('#target0', 'down'); On 2016/09/08 19:49:20, Navid Zolghadr wrote: ...
4 years, 3 months ago (2016-09-08 20:00:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322073002/40001
4 years, 3 months ago (2016-09-08 20:08:35 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-08 21:37:11 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 21:39:57 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9947e60b6974b7be66ed932b7f2f64f7067f5ae3
Cr-Commit-Position: refs/heads/master@{#417406}

Powered by Google App Engine
This is Rietveld 408576698