Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2322053002: Canary seems to be working, bump actual LogDog. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
agable
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Canary seems to be working, bump actual LogDog. BUG=chromium:643243 TEST=canary Committed: https://chromium.googlesource.com/chromium/tools/build/+/1f827fb3b6b4ce5185228c00ddbbe0fe53a12fa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/slave/logdog_bootstrap.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dnj
PTAL. Canary run is latest from https://uberchromegw.corp.google.com/i/chromium.infra/waterfall No observed LogDog bootstrapping errors.
4 years, 3 months ago (2016-09-08 19:06:21 UTC) #2
agable
lgtm
4 years, 3 months ago (2016-09-08 19:07:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322053002/1
4 years, 3 months ago (2016-09-08 19:20:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/1f827fb3b6b4ce5185228c00ddbbe0fe53a12fa8
4 years, 3 months ago (2016-09-08 19:24:21 UTC) #7
dnj
4 years, 3 months ago (2016-09-09 23:18:00 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2327103005/ by dnj@chromium.org.

The reason for reverting is: LogDog not working, e.g.:

https://uberchromegw.corp.google.com/i/chromium/builders/Win/builds/46930.

Powered by Google App Engine
This is Rietveld 408576698