Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2322033002: Apple devices do not support CRC32 instructions. Don't believe Clang's lies. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
bsalomon, Chinmay
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Apple devices do not support CRC32 instructions. Don't believe Clang's lies. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322033002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/9441af52aafd59553ab1a2ea52c390400f93e0bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkCpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkOpts.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkChecksum_opts.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mtklein_C
more flutter
4 years, 3 months ago (2016-09-08 17:36:13 UTC) #5
bsalomon
lgtm
4 years, 3 months ago (2016-09-08 18:01:20 UTC) #6
Chinmay
lgtm. Thanks for the quick fix!
4 years, 3 months ago (2016-09-08 18:04:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322033002/1
4 years, 3 months ago (2016-09-08 18:05:15 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 18:22:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9441af52aafd59553ab1a2ea52c390400f93e0bb

Powered by Google App Engine
This is Rietveld 408576698