Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2322013002:
Check frame for nullptr in WebCore::AutoscrollController::animate (Closed)
DescriptionCheck frame for nullptr in WebCore::AutoscrollController::animate
The previous solution at https://codereview.chromium.org/2316113003/ does not check
all the frames for nullptr. This patch solves the problem in a more clean and
thorough way.
BUG=361036
Committed: https://crrev.com/5f8dfe18539467f3b5efa7b9b9f2585c48d9b62f
Cr-Commit-Position: refs/heads/master@{#417399}
Patch Set 1 #Patch Set 2 : Update the solution #Patch Set 3 : Small fix for windows #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Rewrite: Check frame for nullptr in WebCore::AutoscrollController The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 ========== to ========== Rewrite: Check frame for nullptr in WebCore::AutoscrollController The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 ==========
sunyunjia@chromium.org changed reviewers: + bokan@chromium.org, dtapuska@chromium.org
Description was changed from ========== Rewrite: Check frame for nullptr in WebCore::AutoscrollController The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 ========== to ========== Rewrite: Check frame for nullptr in WebCore::AutoscrollController::animate The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 ==========
Sorry, I should've waited for dtapuska@ 's comment before hitting commit for the previous patch. Please take a look at this new one. Thanks!
On 2016/09/08 20:04:36, sunyunjia wrote: > Sorry, I should've waited for dtapuska@ 's comment before hitting commit for the > previous patch. Please take a look at this new one. Thanks! lgtm
lgtm. Please fix the description, the first line should be separated from the rest of the description. Please remove "Rewrite:".
Description was changed from ========== Rewrite: Check frame for nullptr in WebCore::AutoscrollController::animate The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 ========== to ========== Check frame for nullptr in WebCore::AutoscrollController::animate The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 ==========
The CQ bit was checked by sunyunjia@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Check frame for nullptr in WebCore::AutoscrollController::animate The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 ========== to ========== Check frame for nullptr in WebCore::AutoscrollController::animate The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Check frame for nullptr in WebCore::AutoscrollController::animate The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 ========== to ========== Check frame for nullptr in WebCore::AutoscrollController::animate The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 Committed: https://crrev.com/5f8dfe18539467f3b5efa7b9b9f2585c48d9b62f Cr-Commit-Position: refs/heads/master@{#417399} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/5f8dfe18539467f3b5efa7b9b9f2585c48d9b62f Cr-Commit-Position: refs/heads/master@{#417399} |
