Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2321993002: [stubs] CSA::CopyFixedArrayElements() is now able to convert elements' kind while copying. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] CSA::CopyFixedArrayElements() is now able to convert elements' kind while copying. Drive-by-fix: the old code never triggered write barrier. Committed: https://crrev.com/aec5a80bb7956b6aba3f190a4fd528fbc5bf8f12 Cr-Commit-Position: refs/heads/master@{#39289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -31 lines) Patch
M src/code-stub-assembler.h View 1 chunk +25 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +146 lines, -30 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-08 14:08:41 UTC) #6
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-09-08 17:13:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321993002/20001
4 years, 3 months ago (2016-09-08 17:14:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-08 17:17:10 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:17:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aec5a80bb7956b6aba3f190a4fd528fbc5bf8f12
Cr-Commit-Position: refs/heads/master@{#39289}

Powered by Google App Engine
This is Rietveld 408576698