Custom Elements: layout tests for observedAttributes

Custom Elements: layout tests for observedAttributes

1. attributeChangedCallback should be fired only from
the elements in observedAttributes
2. Checks for cases when converting observedAttributes
to sequence<DOMString> should throw TypeError
https://heycam.github.io/webidl/#create-sequence-from-iterable

BUG=643049
Committed: https://crrev.com/75613110cd274c6fee47675dfe78df3ba20205f4
Cr-Commit-Position: refs/heads/master@{#418761}

[davaajav, 2016-09-09 06:17:51]

Description was changed from

==========
Custom Elements: layout tests for observedAttributes

The following tests should work after
https://codereview.chromium.org/2316263003 gets committed

BUG=643049
==========

to

==========
Custom Elements: layout tests for observedAttributes

1. attributeChangedCallback should be fired only from
the elements in observedAttributes
2. Checks for cases when converting observedAttributes
to sequence<DOMString> should throw TypeError
https://heycam.github.io/webidl/#create-sequence-from-iterable

BUG=643049
==========

[davaajav, 2016-09-09 06:17:51]

davaajav@google.com changed reviewers:
+ bashi@chromium.org, dominicc@chromium.org, haraken@chromium.org,
kojii@chromium.org

[davaajav, 2016-09-09 06:18:03]

PTL

[dominicc (has gone to gerrit), 2016-09-12 05:31:44]

LGTM modulo some ideas about wording, inline.

Thanks for adding these tests!

https://codereview.chromium.org/2321903003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html
(right):

https://codereview.chromium.org/2321903003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html:367: },
'ObservedAttributes');
Could you write prose here? Like observed attributes are retrieved from
iterators or something like that?

It might be worth having two or three attributes, too, instead of just one.

https://codereview.chromium.org/2321903003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html:376: },
'Converting observedAttributes to sequence<DOMString>, not an object');
Maybe write

... non-object observedAttributes ...

and remove , not an object.

What you have is a tiny bit confusing, it sounds a bit like you're *not
converting observedAttributes to an object, but to a sequence<DOMString>.* That
is true, but not what's interesting about this test.

[haraken, 2016-09-12 05:41:29]

LGTM

[davaajav, 2016-09-12 08:14:29]

PTL

[bashi, 2016-09-12 22:40:42]

lgtm, thank you for adding tests!

[dominicc (has gone to gerrit), 2016-09-15 01:20:49]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-09-15 01:20:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2321903003/#ps40001
(title: "updates in comment")

[commit-bot: I haz the power, 2016-09-15 01:21:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 02:27:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 02:30:19]

Description was changed from

==========
Custom Elements: layout tests for observedAttributes

1. attributeChangedCallback should be fired only from
the elements in observedAttributes
2. Checks for cases when converting observedAttributes
to sequence<DOMString> should throw TypeError
https://heycam.github.io/webidl/#create-sequence-from-iterable

BUG=643049
==========

to

==========
Custom Elements: layout tests for observedAttributes

1. attributeChangedCallback should be fired only from
the elements in observedAttributes
2. Checks for cases when converting observedAttributes
to sequence<DOMString> should throw TypeError
https://heycam.github.io/webidl/#create-sequence-from-iterable

BUG=643049

Committed: https://crrev.com/75613110cd274c6fee47675dfe78df3ba20205f4
Cr-Commit-Position: refs/heads/master@{#418761}
==========

[commit-bot: I haz the power, 2016-09-15 02:30:20]

Patchset 3 (id:??) landed as
https://crrev.com/75613110cd274c6fee47675dfe78df3ba20205f4
Cr-Commit-Position: refs/heads/master@{#418761}