Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2321863002: Convert fast/dom/Range/deleteData-replaceData-count-overflow.html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert fast/dom/Range/deleteData-replaceData-count-overflow.html to use w3c test harness This patch converts "fast/dom/Range/deleteData-replaceData-count-overflow.html" to use w3c test harness to simplify test case and make this test script independent from selection behavior, since this test script verifies methods of |Range| object, for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/30d9858f1399f7f7bba8260c80c4d032da35eba9 Cr-Commit-Position: refs/heads/master@{#417208}

Patch Set 1 : 2016-09-08T11:01:54 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -51 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Range/deleteData-replaceData-count-overflow.html View 1 chunk +35 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Range/deleteData-replaceData-count-overflow-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-09-08 04:01:08 UTC) #8
Xiaocheng
lgtm
4 years, 3 months ago (2016-09-08 06:29:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321863002/1
4 years, 3 months ago (2016-09-08 06:47:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 06:51:35 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 06:53:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30d9858f1399f7f7bba8260c80c4d032da35eba9
Cr-Commit-Position: refs/heads/master@{#417208}

Powered by Google App Engine
This is Rietveld 408576698