Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2321843002: [ios] Reload the page inside WebTestWithWebState::LoadHtml if necessary. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Reload the page inside WebTestWithWebState::LoadHtml if necessary. Reload the page if script execution fails. Page reload was performed for data URLs and looks like it's also needed for loadHTML:baseURL: API. BUG=643835 Committed: https://crrev.com/fba2a1c1bf73acfc7ceee1a781aa4f2efbf2a2c4 Cr-Commit-Position: refs/heads/master@{#418919}

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/web/public/test/web_test_with_web_state.mm View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Eugene But (OOO till 7-30)
4 years, 3 months ago (2016-09-13 17:24:54 UTC) #4
Jackie Quinn
On 2016/09/13 17:24:54, Eugene But wrote: lgtm, though is there any chance of an infinite ...
4 years, 3 months ago (2016-09-15 17:25:43 UTC) #7
Eugene But (OOO till 7-30)
On 2016/09/15 17:25:43, Jackie Quinn wrote: > On 2016/09/13 17:24:54, Eugene But wrote: > > ...
4 years, 3 months ago (2016-09-15 17:53:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321843002/20001
4 years, 3 months ago (2016-09-15 17:54:21 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 18:49:19 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 18:51:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fba2a1c1bf73acfc7ceee1a781aa4f2efbf2a2c4
Cr-Commit-Position: refs/heads/master@{#418919}

Powered by Google App Engine
This is Rietveld 408576698