Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 232183002: Chromium side changes to add the ledger API. (Closed)

Created:
6 years, 8 months ago by rkc
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : merge #

Patch Set 6 : #

Patch Set 7 : test fix #

Patch Set 8 : #

Patch Set 9 : merge #

Patch Set 10 : latest merge #

Patch Set 11 : merge chrome_api_permissions.cc #

Patch Set 12 : #

Patch Set 13 : merge #

Patch Set 14 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -11 lines) Patch
M build/json_schema_compile.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M tools/json_schema_compiler/compiler.py View 1 4 chunks +18 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 51 (0 generated)
rkc
6 years, 8 months ago (2014-04-09 22:28:24 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/232183002/diff/1/chrome/common/extensions/api/_api_features.json File chrome/common/extensions/api/_api_features.json (right): https://codereview.chromium.org/232183002/diff/1/chrome/common/extensions/api/_api_features.json#newcode449 chrome/common/extensions/api/_api_features.json:449: "channel": "dev", if you haven't even implemented this API ...
6 years, 8 months ago (2014-04-09 23:50:03 UTC) #2
rkc
Also made a couple more changes to the build. Once I wiped by built and ...
6 years, 8 months ago (2014-04-10 03:08:31 UTC) #3
not at google - send to devlin
https://codereview.chromium.org/232183002/diff/1/chrome/common/extensions/api/_api_features.json File chrome/common/extensions/api/_api_features.json (right): https://codereview.chromium.org/232183002/diff/1/chrome/common/extensions/api/_api_features.json#newcode449 chrome/common/extensions/api/_api_features.json:449: "channel": "dev", On 2014/04/10 03:08:31, Rahul Chaturvedi wrote: > ...
6 years, 8 months ago (2014-04-10 14:28:41 UTC) #4
rkc
https://codereview.chromium.org/232183002/diff/1/chrome/common/extensions/api/_api_features.json File chrome/common/extensions/api/_api_features.json (right): https://codereview.chromium.org/232183002/diff/1/chrome/common/extensions/api/_api_features.json#newcode449 chrome/common/extensions/api/_api_features.json:449: "channel": "dev", On 2014/04/10 14:28:41, kalman wrote: > On ...
6 years, 8 months ago (2014-04-10 21:04:55 UTC) #5
not at google - send to devlin
lgtm https://codereview.chromium.org/232183002/diff/40001/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/232183002/diff/40001/chrome/common/extensions/api/_permission_features.json#newcode515 chrome/common/extensions/api/_permission_features.json:515: "extension_types": ["platform_app"] no reason this can't be extensions ...
6 years, 8 months ago (2014-04-10 21:09:38 UTC) #6
rkc
https://codereview.chromium.org/232183002/diff/40001/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/232183002/diff/40001/chrome/common/extensions/api/_permission_features.json#newcode515 chrome/common/extensions/api/_permission_features.json:515: "extension_types": ["platform_app"] On 2014/04/10 21:09:39, kalman wrote: > no ...
6 years, 8 months ago (2014-04-10 21:12:09 UTC) #7
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 8 months ago (2014-04-14 21:09:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/50001
6 years, 8 months ago (2014-04-14 21:09:49 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 21:09:55 UTC) #10
commit-bot: I haz the power
Failed to apply patch for extensions/browser/extension_function_histogram_value.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-14 21:09:55 UTC) #11
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 8 months ago (2014-04-14 21:26:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/60001
6 years, 8 months ago (2014-04-14 21:26:41 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 22:00:04 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel tryserver.chromium on linux_chromium_gn_rel
6 years, 8 months ago (2014-04-14 22:00:04 UTC) #15
Ilya Sherman
Please run the script to update histograms.xml
6 years, 8 months ago (2014-04-14 22:40:43 UTC) #16
rkc
Done.
6 years, 8 months ago (2014-04-14 22:45:42 UTC) #17
Ilya Sherman
histograms lgtm
6 years, 8 months ago (2014-04-14 22:46:07 UTC) #18
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 8 months ago (2014-04-14 22:46:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/80001
6 years, 8 months ago (2014-04-14 22:50:13 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 23:34:59 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-14 23:35:00 UTC) #22
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 8 months ago (2014-04-14 23:36:32 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/80001
6 years, 8 months ago (2014-04-14 23:37:03 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 23:51:04 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-14 23:51:04 UTC) #26
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 8 months ago (2014-04-15 00:08:12 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/90001
6 years, 8 months ago (2014-04-15 00:09:29 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 01:58:49 UTC) #29
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=65421
6 years, 8 months ago (2014-04-15 01:58:50 UTC) #30
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 8 months ago (2014-04-15 02:12:25 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/90001
6 years, 8 months ago (2014-04-15 02:13:25 UTC) #32
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 04:00:14 UTC) #33
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=65429
6 years, 8 months ago (2014-04-15 04:00:15 UTC) #34
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 8 months ago (2014-04-15 18:51:28 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/90001
6 years, 8 months ago (2014-04-15 18:51:52 UTC) #36
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 20:37:07 UTC) #37
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=65603
6 years, 8 months ago (2014-04-15 20:37:08 UTC) #38
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 7 months ago (2014-05-07 01:05:34 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/150001
6 years, 7 months ago (2014-05-07 01:08:33 UTC) #40
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 19:19:26 UTC) #41
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 19:53:25 UTC) #42
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/permissions/chrome_api_permissions.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-07 19:53:26 UTC) #43
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 7 months ago (2014-05-08 05:23:42 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/170001
6 years, 7 months ago (2014-05-08 05:26:49 UTC) #45
rkc
The CQ bit was unchecked by rkc@chromium.org
6 years, 7 months ago (2014-05-08 05:35:51 UTC) #46
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 7 months ago (2014-05-08 05:36:10 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/232183002/190001
6 years, 7 months ago (2014-05-08 05:36:37 UTC) #48
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 13:35:16 UTC) #49
commit-bot: I haz the power
Failed to apply patch for extensions/browser/extension_function_histogram_value.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-09 13:35:18 UTC) #50
rkc
6 years, 7 months ago (2014-05-12 18:17:48 UTC) #51
Message was sent while issue was closed. 
Committed patchset #14 manually as r269820 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698