Exclude exe files while unzipping CRXes

extensions/utility/utility_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/utility/utility_handler.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/i18n/rtl.h"
 #include "content/public/utility/utility_thread.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_l10n_util.h"
 #include "extensions/common/extension_utility_messages.h"
 #include "extensions/common/extensions_client.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/update_manifest.h"
 #include "extensions/strings/grit/extensions_strings.h"
+#include "extensions/utility/extension_extractor_filter.h"
 #include "extensions/utility/unpacker.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_message_macros.h"
 #include "third_party/zlib/google/zip.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/ui_base_switches.h"
 
 namespace extensions {
 
 namespace {
@@ skipping 44 matching lines @@
         manifest.errors()));
   } else {
     Send(new ExtensionUtilityHostMsg_ParseUpdateManifest_Succeeded(
         manifest.results()));
   }
   ReleaseProcessIfNeeded();
 }
 
 void UtilityHandler::OnUnzipToDir(const base::FilePath& zip_path,
                                   const base::FilePath& dir) {
-  if (!zip::Unzip(zip_path, dir)) {
+  scoped_refptr<ExtensionExtractorFilter> filter =
+      new ExtensionExtractorFilter();
+  const base::Callback<bool(const base::FilePath&)>& filter_cb =
+      base::Bind(&ExtensionExtractorFilter::ShouldExtractFile, filter);
+  if (!zip::UnzipWithFilterCallback(zip_path, dir, filter_cb)) {

[Devlin, 2016/09/08 21:10:16]

This will silently ignore all .exe files.  That's probably good in the case of
normal installations, but I wonder if we can add an install warning for unpacked
extensions and/or when packing an extension to warn about this.

I'm fine with doing that in a separate patch, but can we add a TODO?

[meacer, 2016/09/08 22:40:11]

Done.

     Send(new ExtensionUtilityHostMsg_UnzipToDir_Failed(
         std::string(kExtensionHandlerUnzipError)));
   } else {
     Send(new ExtensionUtilityHostMsg_UnzipToDir_Succeeded(dir));
   }
 
   ReleaseProcessIfNeeded();
 }
 
 void UtilityHandler::OnUnpackExtension(const base::FilePath& directory_path,
@@ skipping 11 matching lines @@
         *unpacker.parsed_manifest()));
   } else {
     Send(new ExtensionUtilityHostMsg_UnpackExtension_Failed(
         unpacker.error_message()));
   }
   ReleaseProcessIfNeeded();
 }
 
 
 }  // namespace extensions