extensions/utility/extension_extractor_filter.cc - Issue 2321823002: Exclude exe files while unzipping CRXes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/utility/extension_extractor_filter.cc

Issue 2321823002: Exclude exe files while unzipping CRXes (Closed)

Patch Set: Fix build Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "extensions/utility/extension_extractor_filter.h"

	6

	7 #include "base/files/file_path.h"

	8 #include "base/macros.h"

	9

	10 namespace extensions {

	11

	12 bool ExtensionExtractorFilter::ShouldExtractFile(

	13 const base::FilePath& file_path) {

	14 return file_path.Extension() != FILE_PATH_LITERAL(".exe");
	Devlin 2016/09/08 21:10:16 Should this be FinalExtension()? Should this be FinalExtension()? meacer 2016/09/08 22:40:10 Extension() and FinalExtension() seems to differ o Show quoted text On 2016/09/08 21:10:16, Devlin wrote: > Should this be FinalExtension()? Extension() and FinalExtension() seems to differ only if the first extension is one of "gz", "z", "bz2" and "bz", but changed it to FinalExtension to be safe.
	15 }

	16

	17 } // namespace extensions

OLD	NEW