Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2321773003: Allow jinja_template_resources to have deps (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews, skym, amineer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow jinja_template_resources to have deps BUG=641888 Committed: https://crrev.com/951cef6ba9bbb147c9ce28d1cf3288b2438125e1 Cr-Commit-Position: refs/heads/master@{#417332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/config/android/rules.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Peter Wen
lgtm
4 years, 3 months ago (2016-09-08 16:15:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321773003/1
4 years, 3 months ago (2016-09-08 16:17:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 17:48:44 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:52:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/951cef6ba9bbb147c9ce28d1cf3288b2438125e1
Cr-Commit-Position: refs/heads/master@{#417332}

Powered by Google App Engine
This is Rietveld 408576698