Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2321773002: pathops tiger checkpoint (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Skip adding coincident edges found during curve intersection if their ends are nearly the same. Loosen conic/line intersection point check. Detect when coincident points are unordered. This means that points a/b/c on one curve may appear in b/c/a order on the opposite curve. Restructure addMissing to return success and return if a coincidence was added as a parameter. With this, tiger part a works. Tiger part b exposes bugs around tight quads that are nearly coincident with themselves, and are coincident with something else. The greedy coicident matcher may cause the point order to be out of sync. Still working out what to do in this case. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321773002 Committed: https://skia.googlesource.com/skia/+/81a478ca6c36aac3e53ce0373a281ac8940f4780

Patch Set 1 #

Patch Set 2 : wip; add missing returns false on fail #

Patch Set 3 : wip; isolate why it fails only in release #

Patch Set 4 : fix uninitialized return value #

Patch Set 5 : checkpoint (all not-under-development tests work) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -2189 lines) Patch
M src/pathops/SkAddIntersections.cpp View 2 chunks +9 lines, -1 line 0 comments Download
M src/pathops/SkDConicLineIntersection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.h View 1 8 chunks +17 lines, -11 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 2 3 4 18 chunks +90 lines, -61 lines 0 comments Download
M src/pathops/SkOpSpan.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/pathops/SkOpSpan.cpp View 1 2 chunks +10 lines, -10 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 3 chunks +13 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 10 chunks +12 lines, -17 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 2 3 4 2 chunks +79 lines, -2 lines 0 comments Download
M tools/pathops_sorter.htm View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 2 3 2 chunks +16 lines, -2074 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321773002/80001
4 years, 3 months ago (2016-09-09 16:11:34 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 16:38:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/81a478ca6c36aac3e53ce0373a281ac8940f4780

Powered by Google App Engine
This is Rietveld 408576698