Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2321743002: Inline content_[tests/browser/android].gypi into GN build. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, tzik, yzshen+watch_chromium.org, tracing+reviews_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, awdf+watch_chromium.org, iclelland+watch_chromium.org, viettrungluu+watch_chromium.org, jam, chasej+watch_chromium.org, abarth-chromium, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, blink-worker-reviews_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, nhiroki, piman+watch_chromium.org, michaeln, shimazu+serviceworker_chromium.org, wfh+watch_chromium.org, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, horo+watch_chromium.org, darin (slow to review), pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline content_[tests/browser/android].gypi into GN build. Delete remaining content gypi files. TBR=jam@chromium.org Committed: https://crrev.com/b167c733caf19fdfa9fcfd49d5b579a69b2ec2dc Cr-Commit-Position: refs/heads/master@{#417105}

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : gen file fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2578 lines, -7578 lines) Patch
D content/app/resources/content_resources.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D content/app/strings/content_strings.gyp View 1 chunk +0 lines, -30 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 8 chunks +1469 lines, -48 lines 0 comments Download
D content/browser/background_sync/background_sync_proto.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D content/browser/browser.gni View 1 chunk +0 lines, -16 lines 0 comments Download
D content/browser/cache_storage/cache_storage_proto.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D content/browser/devtools/devtools.gyp View 1 chunk +0 lines, -47 lines 0 comments Download
D content/browser/devtools/devtools_resources.gyp View 1 chunk +0 lines, -71 lines 0 comments Download
D content/browser/gpu/test_support_gpu.gypi View 1 chunk +0 lines, -53 lines 0 comments Download
D content/browser/notifications/notification_proto.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D content/browser/service_worker/service_worker_proto.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D content/browser/speech/proto/speech_proto.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
D content/browser/tracing/tracing_resources.gyp View 1 chunk +0 lines, -102 lines 0 comments Download
D content/content.gyp View 1 chunk +0 lines, -728 lines 0 comments Download
D content/content_app.gypi View 1 chunk +0 lines, -65 lines 0 comments Download
D content/content_browser.gypi View 1 chunk +0 lines, -2127 lines 0 comments Download
D content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -60 lines 0 comments Download
D content/content_gpu.gypi View 1 chunk +0 lines, -59 lines 0 comments Download
D content/content_jni.gypi View 1 chunk +0 lines, -48 lines 0 comments Download
D content/content_nacl_nonsfi.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D content/content_ppapi_plugin.gypi View 1 chunk +0 lines, -35 lines 0 comments Download
D content/content_renderer.gypi View 1 chunk +0 lines, -915 lines 0 comments Download
D content/content_resources.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
D content/content_shell.gypi View 1 chunk +0 lines, -924 lines 0 comments Download
D content/content_shell_and_tests.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D content/content_tests.gypi View 1 1 chunk +0 lines, -1938 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +34 lines, -6 lines 0 comments Download
M content/public/browser/BUILD.gn View 2 chunks +245 lines, -5 lines 0 comments Download
M content/test/BUILD.gn View 1 14 chunks +830 lines, -73 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
brettw
4 years, 3 months ago (2016-09-07 19:54:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321743002/1
4 years, 3 months ago (2016-09-07 19:54:36 UTC) #3
brettw
Merge
4 years, 3 months ago (2016-09-07 19:59:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321743002/20001
4 years, 3 months ago (2016-09-07 19:59:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/124865) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-07 20:09:34 UTC) #8
brettw
gen file fix
4 years, 3 months ago (2016-09-07 21:08:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321743002/40001
4 years, 3 months ago (2016-09-07 21:08:40 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 22:53:08 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:55:15 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b167c733caf19fdfa9fcfd49d5b579a69b2ec2dc
Cr-Commit-Position: refs/heads/master@{#417105}

Powered by Google App Engine
This is Rietveld 408576698