Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2225)

Unified Diff: appengine_scripts/skia-tree-status/skia_telemetry.py

Issue 232173006: Add a new 'Repeat Pageset Runs' checkbox to the Chromium Tryserver (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine_scripts/skia-tree-status/templates/all_tasks.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine_scripts/skia-tree-status/skia_telemetry.py
diff --git a/appengine_scripts/skia-tree-status/skia_telemetry.py b/appengine_scripts/skia-tree-status/skia_telemetry.py
index a2d1ea60d398c23e9f7ee84929fb4eec9ef2e146..fbf3df17fc650e9a379268ab47fa5a286ea2d344 100644
--- a/appengine_scripts/skia-tree-status/skia_telemetry.py
+++ b/appengine_scripts/skia-tree-status/skia_telemetry.py
@@ -336,6 +336,7 @@ class ChromiumTryTasks(BaseTelemetryModel):
skia_patch = db.BlobProperty()
chromium_patch = db.BlobProperty()
blink_patch = db.BlobProperty()
+ num_repeated_runs = db.IntegerProperty()
variance_threshold = db.FloatProperty(required=True)
discard_outliers = db.FloatProperty(required=True)
requested_time = db.DateTimeProperty(required=True)
@@ -361,6 +362,7 @@ class ChromiumTryTasks(BaseTelemetryModel):
'skia_patch': self.skia_patch,
'chromium_patch': self.chromium_patch,
'blink_patch': self.blink_patch,
+ 'num_repeated_runs': self.num_repeated_runs,
'variance_threshold': self.variance_threshold,
'discard_outliers': self.discard_outliers,
'requested_time': str(self.requested_time)
@@ -847,6 +849,7 @@ class ChromiumTryPage(BasePage):
benchmark_name = self.request.get('benchmark_name')
benchmark_arguments = self.request.get('benchmark_arguments')
pageset_type = self.request.get('pageset_type')
+ num_repeated_runs = int(self.request.get('num_repeated_runs'))
variance_threshold = float(self.request.get('variance_threshold'))
discard_outliers = float(self.request.get('discard_outliers'))
description = self.request.get('description')
@@ -865,6 +868,7 @@ class ChromiumTryPage(BasePage):
skia_patch=skia_patch,
chromium_patch=chromium_patch,
blink_patch=blink_patch,
+ num_repeated_runs=num_repeated_runs,
variance_threshold=variance_threshold,
discard_outliers=discard_outliers,
requested_time=requested_time,
« no previous file with comments | « no previous file | appengine_scripts/skia-tree-status/templates/all_tasks.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698