Issue 232173003: ozone: Protect X11-specific code in chrome/browser/metrics

Issue 232173003: ozone: Protect X11-specific code in chrome/browser/metrics (Closed)

Created:
6 years, 8 months ago by spang

Modified:
6 years, 8 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ozone: Protect X11-specific code in chrome/browser/metrics This fixes some build errors for the "chromeos=1 use_ozone=1" build. The touch factory class is currently only supported under X11. BUG=361341 TEST=chrome --ozone-platform=test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262930

Patch Set 1 #

Total comments: 4

Patch Set 2 : add // defined(USE_X11) #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/browser/metrics/metrics_log_chromeos.cc	View	1	3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

https://codereview.chromium.org/232173003/diff/1/chrome/browser/metrics/metrics_log_chromeos.cc File chrome/browser/metrics/metrics_log_chromeos.cc (right): https://codereview.chromium.org/232173003/diff/1/chrome/browser/metrics/metrics_log_chromeos.cc#newcode22 chrome/browser/metrics/metrics_log_chromeos.cc:22: #endif nit: " // defined(USE_X11)" https://codereview.chromium.org/232173003/diff/1/chrome/browser/metrics/metrics_log_chromeos.cc#newcode80 chrome/browser/metrics/metrics_log_chromeos.cc:80: #endif nit: ...

6 years, 8 months ago (2014-04-09 23:56:50 UTC) #2

spang

https://codereview.chromium.org/232173003/diff/1/chrome/browser/metrics/metrics_log_chromeos.cc File chrome/browser/metrics/metrics_log_chromeos.cc (right): https://codereview.chromium.org/232173003/diff/1/chrome/browser/metrics/metrics_log_chromeos.cc#newcode22 chrome/browser/metrics/metrics_log_chromeos.cc:22: #endif On 2014/04/09 23:56:50, Ilya Sherman wrote: > nit: ...

6 years, 8 months ago (2014-04-10 00:09:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/232173003/20001

6 years, 8 months ago (2014-04-10 00:12:56 UTC) #6

Message was sent while issue was closed.

Change committed as 262930

Expand Messages | Collapse Messages