Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2321673002: Add minimal support for readPixels in raster F16 (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add minimal support for readPixels in raster F16 Still doesn't support doing premul <-> unpremul conversions, but handles the simple cases (which would previously always fail). Fixes the new gamut gm (partially) in f16 config. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321673002 Committed: https://skia.googlesource.com/skia/+/c544e7043c9727fb5697120e241b6860816ef749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/core/SkConfig8888.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
4 years, 3 months ago (2016-09-07 17:47:54 UTC) #5
reed1
do we have any tests/gms to update to exercise this? lgtm
4 years, 3 months ago (2016-09-07 18:10:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321673002/1
4 years, 3 months ago (2016-09-07 18:29:54 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 18:30:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c544e7043c9727fb5697120e241b6860816ef749

Powered by Google App Engine
This is Rietveld 408576698