Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

Issue 2321663002: [telemetry] Make browser finding on android tolerate device faults. (Closed)
Patch Set: nit: import order Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
diff --git a/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py b/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
index 5797ef824beb1d799e6f6fa3ebbb375ce2206d33..3eda4a5e8da2c5a4b1cbc9fb1b98284366d9be0a 100644
--- a/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
+++ b/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
@@ -9,6 +9,7 @@ import os
import sys
from py_utils import dependency_util
+from devil import base_error
from devil.android import apk_helper
from telemetry.core import exceptions
@@ -255,5 +256,10 @@ def FindAllAvailableBrowsers(finder_options, device):
"""
if not isinstance(device, android_device.AndroidDevice):
return []
- android_platform = platform.GetPlatformForDevice(device, finder_options)
- return _FindAllPossibleBrowsers(finder_options, android_platform)
+
+ try:
+ android_platform = platform.GetPlatformForDevice(device, finder_options)
+ return _FindAllPossibleBrowsers(finder_options, android_platform)
+ except base_error.BaseError as e:
+ logging.error('Unable to find browsers on %s: %s', device.device_id, str(e))
+ return []
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698