Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2321623003: Asset management: Download from GS store instead of CIPD (Closed)

Created:
4 years, 3 months ago by borenet2
Modified:
4 years, 3 months ago
Reviewers:
msarett, borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Asset management: Download from GS store instead of CIPD This avoids strange CIPD symlink/permissions issues BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321623003 Committed: https://skia.googlesource.com/skia/+/2172d55eb5c76d0e9f15cf7faa72014c8f49209b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/bots/assets/asset_utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
borenet
4 years, 3 months ago (2016-09-08 13:10:46 UTC) #3
msarett
On 2016/09/08 13:10:46, borenet wrote: lgtm
4 years, 3 months ago (2016-09-08 13:18:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321623003/1
4 years, 3 months ago (2016-09-08 13:19:31 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 13:56:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2172d55eb5c76d0e9f15cf7faa72014c8f49209b

Powered by Google App Engine
This is Rietveld 408576698