Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2321573003: Check if response headers are empty in signin code (Closed)

Created:
4 years, 3 months ago by jianli
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if response headers are empty in signin code BUG=644623 Committed: https://crrev.com/211bb9dcc3fbc30da789790def12f8771db76ce2 Cr-Commit-Position: refs/heads/master@{#417049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/signin/core/browser/signin_header_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jianli
4 years, 3 months ago (2016-09-07 19:50:56 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
4 years, 3 months ago (2016-09-07 19:52:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321573003/1
4 years, 3 months ago (2016-09-07 19:54:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 21:40:28 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:42:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/211bb9dcc3fbc30da789790def12f8771db76ce2
Cr-Commit-Position: refs/heads/master@{#417049}

Powered by Google App Engine
This is Rietveld 408576698