Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2321563007: [test] Fix the noi18n trybot (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix the noi18n trybot This is a work-around as v8_enable_i18n_support=false does currently not imply icu_use_data_file_flag=false. The swarming isolator then tries to find the data file also in builds without ICU. Making the implication is non-trivial as icu_use_data_file_flag lives in ICU and v8_enable_i18n_support lives in V8. BUG=chromium:474921 NOTRY=true TBR=petermarshall@chromium.org, vogelheim@chromium.org, jochen@chromium.org Committed: https://crrev.com/bcc3cb2ea4e0729337fb90dfcee8e171e9b30292 Cr-Commit-Position: refs/heads/master@{#39301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M infra/mb/mb_config.pyl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Achenbach
PTAL. Hijacking your CL...
4 years, 3 months ago (2016-09-09 08:14:58 UTC) #3
petermarshall
lgtm
4 years, 3 months ago (2016-09-09 08:18:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321563007/1
4 years, 3 months ago (2016-09-09 08:20:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 08:23:29 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 08:23:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcc3cb2ea4e0729337fb90dfcee8e171e9b30292
Cr-Commit-Position: refs/heads/master@{#39301}

Powered by Google App Engine
This is Rietveld 408576698