Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2321563004: [GN] Put an obvious dependency on browser (Closed)

Created:
4 years, 3 months ago by peria
Modified:
4 years, 3 months ago
CC:
chromium-reviews, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put an obvious dependency on browser from ui_test. It is expected to fix flaky build failures in the BUG. Using source code names, this CL adds a dependency chrome/test/base/ui_test_utils.cc --> content/public/browser/render_process_host.h Other dependencies content/public/browser/render_process_host.h --> services/shell/public/cpp/interface_registry.h --> out/Release/gen/services/shell/public/interfaces/interface_provider.mojom.h are already written. BUG=633077 Committed: https://crrev.com/11cac3e30beabb6878f6e50a0fd5b657582c665b Cr-Commit-Position: refs/heads/master@{#417485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
peria
PTL
4 years, 3 months ago (2016-09-08 05:15:00 UTC) #5
Paweł Hajdan Jr.
+brettw,dpranke to double-check this is the best way to add it I'm fine with this. ...
4 years, 3 months ago (2016-09-08 12:26:14 UTC) #7
Dirk Pranke
lgtm, but I'm not an owner of this file.
4 years, 3 months ago (2016-09-08 22:11:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321563004/1
4 years, 3 months ago (2016-09-09 01:28:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 02:39:40 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 02:42:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11cac3e30beabb6878f6e50a0fd5b657582c665b
Cr-Commit-Position: refs/heads/master@{#417485}

Powered by Google App Engine
This is Rietveld 408576698