Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2321553002: [heap] Do more incremental marking work in tasks. (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Do more incremental marking work in tasks. This patch changes incremental marking work scheduling from combination of idle/delayed tasks to ordinary short-running tasks and moves more marking work from V8.Execute to tasks by accounting how much bytes were marked in tasks. BUG=chromium:616434 LOG=NO Committed: https://crrev.com/6a1b49d79c610cc981ec35598a8a070951f8c3f7 Cr-Commit-Position: refs/heads/master@{#39348}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -261 lines) Patch
M src/heap/heap.cc View 1 3 chunks +13 lines, -10 lines 0 comments Download
M src/heap/incremental-marking.h View 4 chunks +6 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 7 chunks +27 lines, -5 lines 0 comments Download
M src/heap/incremental-marking-job.h View 2 chunks +10 lines, -43 lines 0 comments Download
M src/heap/incremental-marking-job.cc View 1 chunk +15 lines, -106 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M test/cctest/heap/test-incremental-marking.cc View 7 chunks +20 lines, -81 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
ulan
PTAL
4 years, 3 months ago (2016-09-07 14:23:14 UTC) #3
Michael Lippautz
LGTM, awesome! https://codereview.chromium.org/2321553002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2321553002/diff/1/src/heap/heap.cc#newcode1057 src/heap/heap.cc:1057: // We do this only for scavener ...
4 years, 3 months ago (2016-09-07 15:46:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321553002/20001
4 years, 3 months ago (2016-09-12 11:04:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321553002/20001
4 years, 3 months ago (2016-09-12 11:04:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 11:46:18 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 11:46:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a1b49d79c610cc981ec35598a8a070951f8c3f7
Cr-Commit-Position: refs/heads/master@{#39348}

Powered by Google App Engine
This is Rietveld 408576698