Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: content/browser/loader/resource_loader.cc

Issue 2321543002: Merge CrossSiteResourceHandler and NavigationResourceThrottle (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_loader.cc
diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc
index 1ad243f5f1e142a85770b955ba6fdb3f7952e6f3..de0656f7429b313081db31fd9eaf63444697bd00 100644
--- a/content/browser/loader/resource_loader.cc
+++ b/content/browser/loader/resource_loader.cc
@@ -16,7 +16,6 @@
#include "base/trace_event/trace_event.h"
#include "content/browser/appcache/appcache_interceptor.h"
#include "content/browser/child_process_security_policy_impl.h"
-#include "content/browser/loader/cross_site_resource_handler.h"
#include "content/browser/loader/detachable_resource_handler.h"
#include "content/browser/loader/resource_loader_delegate.h"
#include "content/browser/loader/resource_request_info_impl.h"
@@ -218,10 +217,11 @@ void ResourceLoader::CancelWithError(int error_code) {
}
void ResourceLoader::MarkAsTransferring(
- const scoped_refptr<ResourceResponse>& response) {
+ const base::Closure& on_transfer_complete_callback) {
CHECK(IsResourceTypeFrame(GetRequestInfo()->GetResourceType()))
<< "Can only transfer for navigations";
is_transferring_ = true;
+ on_transfer_complete_ = on_transfer_complete_callback;
int child_id = GetRequestInfo()->GetChildID();
AppCacheInterceptor::PrepareForCrossSiteTransfer(request(), child_id);
@@ -232,13 +232,14 @@ void ResourceLoader::MarkAsTransferring(
}
void ResourceLoader::CompleteTransfer() {
- // Although CrossSiteResourceHandler defers at OnResponseStarted
+ // Although NavigationResourceThrottle defers at WillProcessResponse
// (DEFERRED_READ), it may be seeing a replay of events via
- // MimeTypeResourceHandler, and so the request itself is actually deferred
- // at a later read stage.
+ // MimeTypeResourceHandler, and so the request itself is actually deferred at
+ // a later read stage.
DCHECK(DEFERRED_READ == deferred_stage_ ||
DEFERRED_RESPONSE_COMPLETE == deferred_stage_);
DCHECK(is_transferring_);
+ DCHECK(!on_transfer_complete_.is_null());
// In some cases, a process transfer doesn't really happen and the
// request is resumed in the original process. Real transfers to a new process
@@ -252,7 +253,8 @@ void ResourceLoader::CompleteTransfer() {
handler->MaybeCompleteCrossSiteTransferInOldProcess(child_id);
is_transferring_ = false;
- GetRequestInfo()->cross_site_handler()->ResumeResponse();
+ on_transfer_complete_.Run();
+ on_transfer_complete_.Reset();
}
ResourceRequestInfoImpl* ResourceLoader::GetRequestInfo() {

Powered by Google App Engine
This is Rietveld 408576698