Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2321543002: Merge CrossSiteResourceHandler and NavigationResourceThrottle (Closed)
Patch Set: Addressed nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/BUILD.gn ('k') | content/browser/frame_host/cross_site_transferring_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index e137b9e3e9c6232d3f31fde2598b876d4c8e3d3f..51c5d6ea186bfa434e877dccb002e9b762548c3e 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -563,8 +563,11 @@ RenderFrameDevToolsAgentHost::~RenderFrameDevToolsAgentHost() {
void RenderFrameDevToolsAgentHost::ReadyToCommitNavigation(
NavigationHandle* navigation_handle) {
- // ReadyToCommitNavigation should only be called in PlzNavigate.
- DCHECK(IsBrowserSideNavigationEnabled());
+ // TODO(clamy): Switch RenderFrameDevToolsAgentHost to always buffer messages
+ // until ReadyToCommitNavigation is called, now that it is also called in
+ // non-PlzNavigate mode.
+ if (!IsBrowserSideNavigationEnabled())
+ return;
// If the navigation is not tracked, return;
if (navigating_handles_.count(navigation_handle) == 0)
« no previous file with comments | « content/browser/BUILD.gn ('k') | content/browser/frame_host/cross_site_transferring_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698