Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: content/browser/loader/navigation_resource_throttle.h

Issue 2321543002: Merge CrossSiteResourceHandler and NavigationResourceThrottle (Closed)
Patch Set: Change to android fix + compile error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/navigation_resource_throttle.h
diff --git a/content/browser/loader/navigation_resource_throttle.h b/content/browser/loader/navigation_resource_throttle.h
index 55a1da5d1519588327dd2f06a0196778fe728d15..57fbfbe81280eef68822eaa380b1e38c64442993 100644
--- a/content/browser/loader/navigation_resource_throttle.h
+++ b/content/browser/loader/navigation_resource_throttle.h
@@ -7,6 +7,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "content/common/content_export.h"
#include "content/public/browser/navigation_throttle.h"
#include "content/public/browser/resource_throttle.h"
#include "content/public/common/request_context_type.h"
@@ -36,12 +37,28 @@ class NavigationResourceThrottle : public ResourceThrottle {
void WillProcessResponse(bool* defer) override;
const char* GetNameForLogging() const override;
+ // Used in unit tests to make UI checks pass when they would fail due to no
+ // NavigationHandle being present in the RenderFrameHost.
+ CONTENT_EXPORT static void SetUIChecksAlwaysSucceedForTesting(
+ bool ui_checks_always_succeed);
+
+ // Used in unit tests to make all navigations transfer.
+ CONTENT_EXPORT static void SetForceTransferForTesting(
+ bool force_transfer);
+
private:
void OnUIChecksPerformed(NavigationThrottle::ThrottleCheckResult result);
+ // Used in transfer navigations.
+ void InitiateTransfer();
+ void OnTransferComplete();
+
net::URLRequest* request_;
ResourceDispatcherHostDelegate* resource_dispatcher_host_delegate_;
RequestContextType request_context_type_;
+ bool in_cross_site_transition_;
+ NavigationThrottle::ThrottleCheckResult on_transfer_done_result_;
+
base::WeakPtrFactory<NavigationResourceThrottle> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(NavigationResourceThrottle);

Powered by Google App Engine
This is Rietveld 408576698