Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2321543002: Merge CrossSiteResourceHandler and NavigationResourceThrottle (Closed)
Patch Set: Change to android fix + compile error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index c2d13d65aa25319b23562ad25c325714aa6ad509..26cb8c5d3e49a7afaa4b8f4f2f15d3c7afb7d493 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -562,8 +562,11 @@ RenderFrameDevToolsAgentHost::~RenderFrameDevToolsAgentHost() {
void RenderFrameDevToolsAgentHost::ReadyToCommitNavigation(
NavigationHandle* navigation_handle) {
- // ReadyToCommitNavigation should only be called in PlzNavigate.
- DCHECK(IsBrowserSideNavigationEnabled());
+ // TODO(clamy): Switch RenderFrameDevToolsAgentHost to always buffer messages
+ // until ReadyToCommitNavigation is called, now that it is also called in
+ // non-PlzNavigate mode.
+ if (!IsBrowserSideNavigationEnabled())
+ return;
// If the navigation is not tracked, return;
if (navigating_handles_.count(navigation_handle) == 0)

Powered by Google App Engine
This is Rietveld 408576698