Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: content/browser/loader/resource_loader.cc

Issue 2321543002: Merge CrossSiteResourceHandler and NavigationResourceThrottle (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/resource_loader.h" 5 #include "content/browser/loader/resource_loader.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/location.h" 10 #include "base/location.h"
11 #include "base/metrics/histogram_macros.h" 11 #include "base/metrics/histogram_macros.h"
12 #include "base/profiler/scoped_tracker.h" 12 #include "base/profiler/scoped_tracker.h"
13 #include "base/single_thread_task_runner.h" 13 #include "base/single_thread_task_runner.h"
14 #include "base/threading/thread_task_runner_handle.h" 14 #include "base/threading/thread_task_runner_handle.h"
15 #include "base/time/time.h" 15 #include "base/time/time.h"
16 #include "base/trace_event/trace_event.h" 16 #include "base/trace_event/trace_event.h"
17 #include "content/browser/appcache/appcache_interceptor.h" 17 #include "content/browser/appcache/appcache_interceptor.h"
18 #include "content/browser/child_process_security_policy_impl.h" 18 #include "content/browser/child_process_security_policy_impl.h"
19 #include "content/browser/loader/cross_site_resource_handler.h"
20 #include "content/browser/loader/detachable_resource_handler.h" 19 #include "content/browser/loader/detachable_resource_handler.h"
21 #include "content/browser/loader/resource_loader_delegate.h" 20 #include "content/browser/loader/resource_loader_delegate.h"
22 #include "content/browser/loader/resource_request_info_impl.h" 21 #include "content/browser/loader/resource_request_info_impl.h"
23 #include "content/browser/service_worker/service_worker_request_handler.h" 22 #include "content/browser/service_worker/service_worker_request_handler.h"
24 #include "content/browser/service_worker/service_worker_response_info.h" 23 #include "content/browser/service_worker/service_worker_response_info.h"
25 #include "content/browser/ssl/ssl_client_auth_handler.h" 24 #include "content/browser/ssl/ssl_client_auth_handler.h"
26 #include "content/browser/ssl/ssl_manager.h" 25 #include "content/browser/ssl/ssl_manager.h"
27 #include "content/browser/ssl/ssl_policy.h" 26 #include "content/browser/ssl/ssl_policy.h"
28 #include "content/common/security_style_util.h" 27 #include "content/common/security_style_util.h"
29 #include "content/public/browser/resource_dispatcher_host_login_delegate.h" 28 #include "content/public/browser/resource_dispatcher_host_login_delegate.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 CancelRequest(false); 210 CancelRequest(false);
212 } 211 }
213 212
214 void ResourceLoader::CancelWithError(int error_code) { 213 void ResourceLoader::CancelWithError(int error_code) {
215 TRACE_EVENT_WITH_FLOW0("loading", "ResourceLoader::CancelWithError", this, 214 TRACE_EVENT_WITH_FLOW0("loading", "ResourceLoader::CancelWithError", this,
216 TRACE_EVENT_FLAG_FLOW_IN); 215 TRACE_EVENT_FLAG_FLOW_IN);
217 CancelRequestInternal(error_code, false); 216 CancelRequestInternal(error_code, false);
218 } 217 }
219 218
220 void ResourceLoader::MarkAsTransferring( 219 void ResourceLoader::MarkAsTransferring(
221 const scoped_refptr<ResourceResponse>& response) { 220 const base::Closure& on_transfer_complete_callback) {
222 CHECK(IsResourceTypeFrame(GetRequestInfo()->GetResourceType())) 221 CHECK(IsResourceTypeFrame(GetRequestInfo()->GetResourceType()))
223 << "Can only transfer for navigations"; 222 << "Can only transfer for navigations";
224 is_transferring_ = true; 223 is_transferring_ = true;
224 on_transfer_complete_ = on_transfer_complete_callback;
225 225
226 int child_id = GetRequestInfo()->GetChildID(); 226 int child_id = GetRequestInfo()->GetChildID();
227 AppCacheInterceptor::PrepareForCrossSiteTransfer(request(), child_id); 227 AppCacheInterceptor::PrepareForCrossSiteTransfer(request(), child_id);
228 ServiceWorkerRequestHandler* handler = 228 ServiceWorkerRequestHandler* handler =
229 ServiceWorkerRequestHandler::GetHandler(request()); 229 ServiceWorkerRequestHandler::GetHandler(request());
230 if (handler) 230 if (handler)
231 handler->PrepareForCrossSiteTransfer(child_id); 231 handler->PrepareForCrossSiteTransfer(child_id);
232 } 232 }
233 233
234 void ResourceLoader::CompleteTransfer() { 234 void ResourceLoader::CompleteTransfer() {
235 // Although CrossSiteResourceHandler defers at OnResponseStarted 235 // Although NavigationResourceThrottle defers at WillProcessResponse
236 // (DEFERRED_READ), it may be seeing a replay of events via 236 // (DEFERRED_READ), it may be seeing a replay of events via
237 // MimeTypeResourceHandler, and so the request itself is actually deferred 237 // MimeTypeResourceHandler, and so the request itself is actually deferred at
238 // at a later read stage. 238 // a later read stage.
239 DCHECK(DEFERRED_READ == deferred_stage_ || 239 DCHECK(DEFERRED_READ == deferred_stage_ ||
240 DEFERRED_RESPONSE_COMPLETE == deferred_stage_); 240 DEFERRED_RESPONSE_COMPLETE == deferred_stage_);
241 DCHECK(is_transferring_); 241 DCHECK(is_transferring_);
242 DCHECK(!on_transfer_complete_.is_null());
242 243
243 // In some cases, a process transfer doesn't really happen and the 244 // In some cases, a process transfer doesn't really happen and the
244 // request is resumed in the original process. Real transfers to a new process 245 // request is resumed in the original process. Real transfers to a new process
245 // are completed via ResourceDispatcherHostImpl::UpdateRequestForTransfer. 246 // are completed via ResourceDispatcherHostImpl::UpdateRequestForTransfer.
246 int child_id = GetRequestInfo()->GetChildID(); 247 int child_id = GetRequestInfo()->GetChildID();
247 AppCacheInterceptor::MaybeCompleteCrossSiteTransferInOldProcess( 248 AppCacheInterceptor::MaybeCompleteCrossSiteTransferInOldProcess(
248 request(), child_id); 249 request(), child_id);
249 ServiceWorkerRequestHandler* handler = 250 ServiceWorkerRequestHandler* handler =
250 ServiceWorkerRequestHandler::GetHandler(request()); 251 ServiceWorkerRequestHandler::GetHandler(request());
251 if (handler) 252 if (handler)
252 handler->MaybeCompleteCrossSiteTransferInOldProcess(child_id); 253 handler->MaybeCompleteCrossSiteTransferInOldProcess(child_id);
253 254
254 is_transferring_ = false; 255 is_transferring_ = false;
255 GetRequestInfo()->cross_site_handler()->ResumeResponse(); 256 on_transfer_complete_.Run();
257 on_transfer_complete_.Reset();
256 } 258 }
257 259
258 ResourceRequestInfoImpl* ResourceLoader::GetRequestInfo() { 260 ResourceRequestInfoImpl* ResourceLoader::GetRequestInfo() {
259 return ResourceRequestInfoImpl::ForRequest(request_.get()); 261 return ResourceRequestInfoImpl::ForRequest(request_.get());
260 } 262 }
261 263
262 void ResourceLoader::ClearLoginDelegate() { 264 void ResourceLoader::ClearLoginDelegate() {
263 login_delegate_ = NULL; 265 login_delegate_ = NULL;
264 } 266 }
265 267
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 } 747 }
746 748
747 UMA_HISTOGRAM_ENUMERATION("Net.Prefetch.Pattern", status, STATUS_MAX); 749 UMA_HISTOGRAM_ENUMERATION("Net.Prefetch.Pattern", status, STATUS_MAX);
748 } else if (request_->response_info().unused_since_prefetch) { 750 } else if (request_->response_info().unused_since_prefetch) {
749 TimeDelta total_time = base::TimeTicks::Now() - request_->creation_time(); 751 TimeDelta total_time = base::TimeTicks::Now() - request_->creation_time();
750 UMA_HISTOGRAM_TIMES("Net.Prefetch.TimeSpentOnPrefetchHit", total_time); 752 UMA_HISTOGRAM_TIMES("Net.Prefetch.TimeSpentOnPrefetchHit", total_time);
751 } 753 }
752 } 754 }
753 755
754 } // namespace content 756 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698