Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: content/browser/loader/resource_loader.cc

Issue 2321543002: Merge CrossSiteResourceHandler and NavigationResourceThrottle (Closed)
Patch Set: Addressed nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/resource_loader.h" 5 #include "content/browser/loader/resource_loader.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h"
9 #include "base/command_line.h" 10 #include "base/command_line.h"
10 #include "base/location.h" 11 #include "base/location.h"
11 #include "base/metrics/histogram_macros.h" 12 #include "base/metrics/histogram_macros.h"
12 #include "base/profiler/scoped_tracker.h" 13 #include "base/profiler/scoped_tracker.h"
13 #include "base/single_thread_task_runner.h" 14 #include "base/single_thread_task_runner.h"
14 #include "base/threading/thread_task_runner_handle.h" 15 #include "base/threading/thread_task_runner_handle.h"
15 #include "base/time/time.h" 16 #include "base/time/time.h"
16 #include "base/trace_event/trace_event.h" 17 #include "base/trace_event/trace_event.h"
17 #include "content/browser/appcache/appcache_interceptor.h" 18 #include "content/browser/appcache/appcache_interceptor.h"
18 #include "content/browser/child_process_security_policy_impl.h" 19 #include "content/browser/child_process_security_policy_impl.h"
19 #include "content/browser/loader/cross_site_resource_handler.h"
20 #include "content/browser/loader/detachable_resource_handler.h" 20 #include "content/browser/loader/detachable_resource_handler.h"
21 #include "content/browser/loader/resource_loader_delegate.h" 21 #include "content/browser/loader/resource_loader_delegate.h"
22 #include "content/browser/loader/resource_request_info_impl.h" 22 #include "content/browser/loader/resource_request_info_impl.h"
23 #include "content/browser/service_worker/service_worker_request_handler.h" 23 #include "content/browser/service_worker/service_worker_request_handler.h"
24 #include "content/browser/service_worker/service_worker_response_info.h" 24 #include "content/browser/service_worker/service_worker_response_info.h"
25 #include "content/browser/ssl/ssl_client_auth_handler.h" 25 #include "content/browser/ssl/ssl_client_auth_handler.h"
26 #include "content/browser/ssl/ssl_manager.h" 26 #include "content/browser/ssl/ssl_manager.h"
27 #include "content/browser/ssl/ssl_policy.h" 27 #include "content/browser/ssl/ssl_policy.h"
28 #include "content/public/browser/resource_dispatcher_host_login_delegate.h" 28 #include "content/public/browser/resource_dispatcher_host_login_delegate.h"
29 #include "content/public/common/content_client.h" 29 #include "content/public/common/content_client.h"
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 CancelRequest(false); 193 CancelRequest(false);
194 } 194 }
195 195
196 void ResourceLoader::CancelWithError(int error_code) { 196 void ResourceLoader::CancelWithError(int error_code) {
197 TRACE_EVENT_WITH_FLOW0("loading", "ResourceLoader::CancelWithError", this, 197 TRACE_EVENT_WITH_FLOW0("loading", "ResourceLoader::CancelWithError", this,
198 TRACE_EVENT_FLAG_FLOW_IN); 198 TRACE_EVENT_FLAG_FLOW_IN);
199 CancelRequestInternal(error_code, false); 199 CancelRequestInternal(error_code, false);
200 } 200 }
201 201
202 void ResourceLoader::MarkAsTransferring( 202 void ResourceLoader::MarkAsTransferring(
203 const scoped_refptr<ResourceResponse>& response) { 203 const base::Closure& on_transfer_complete_callback) {
204 CHECK(IsResourceTypeFrame(GetRequestInfo()->GetResourceType())) 204 CHECK(IsResourceTypeFrame(GetRequestInfo()->GetResourceType()))
205 << "Can only transfer for navigations"; 205 << "Can only transfer for navigations";
206 is_transferring_ = true; 206 is_transferring_ = true;
207 on_transfer_complete_callback_ = on_transfer_complete_callback;
207 208
208 int child_id = GetRequestInfo()->GetChildID(); 209 int child_id = GetRequestInfo()->GetChildID();
209 AppCacheInterceptor::PrepareForCrossSiteTransfer(request(), child_id); 210 AppCacheInterceptor::PrepareForCrossSiteTransfer(request(), child_id);
210 ServiceWorkerRequestHandler* handler = 211 ServiceWorkerRequestHandler* handler =
211 ServiceWorkerRequestHandler::GetHandler(request()); 212 ServiceWorkerRequestHandler::GetHandler(request());
212 if (handler) 213 if (handler)
213 handler->PrepareForCrossSiteTransfer(child_id); 214 handler->PrepareForCrossSiteTransfer(child_id);
214 } 215 }
215 216
216 void ResourceLoader::CompleteTransfer() { 217 void ResourceLoader::CompleteTransfer() {
217 // Although CrossSiteResourceHandler defers at OnResponseStarted 218 // Although NavigationResourceThrottle defers at WillProcessResponse
218 // (DEFERRED_READ), it may be seeing a replay of events via 219 // (DEFERRED_READ), it may be seeing a replay of events via
219 // MimeTypeResourceHandler, and so the request itself is actually deferred 220 // MimeTypeResourceHandler, and so the request itself is actually deferred at
220 // at a later read stage. 221 // a later read stage.
221 DCHECK(DEFERRED_READ == deferred_stage_ || 222 DCHECK(DEFERRED_READ == deferred_stage_ ||
222 DEFERRED_RESPONSE_COMPLETE == deferred_stage_); 223 DEFERRED_RESPONSE_COMPLETE == deferred_stage_);
223 DCHECK(is_transferring_); 224 DCHECK(is_transferring_);
225 DCHECK(!on_transfer_complete_callback_.is_null());
224 226
225 // In some cases, a process transfer doesn't really happen and the 227 // In some cases, a process transfer doesn't really happen and the
226 // request is resumed in the original process. Real transfers to a new process 228 // request is resumed in the original process. Real transfers to a new process
227 // are completed via ResourceDispatcherHostImpl::UpdateRequestForTransfer. 229 // are completed via ResourceDispatcherHostImpl::UpdateRequestForTransfer.
228 int child_id = GetRequestInfo()->GetChildID(); 230 int child_id = GetRequestInfo()->GetChildID();
229 AppCacheInterceptor::MaybeCompleteCrossSiteTransferInOldProcess( 231 AppCacheInterceptor::MaybeCompleteCrossSiteTransferInOldProcess(
230 request(), child_id); 232 request(), child_id);
231 ServiceWorkerRequestHandler* handler = 233 ServiceWorkerRequestHandler* handler =
232 ServiceWorkerRequestHandler::GetHandler(request()); 234 ServiceWorkerRequestHandler::GetHandler(request());
233 if (handler) 235 if (handler)
234 handler->MaybeCompleteCrossSiteTransferInOldProcess(child_id); 236 handler->MaybeCompleteCrossSiteTransferInOldProcess(child_id);
235 237
236 is_transferring_ = false; 238 is_transferring_ = false;
237 GetRequestInfo()->cross_site_handler()->ResumeResponse(); 239 base::ResetAndReturn(&on_transfer_complete_callback_).Run();
238 } 240 }
239 241
240 ResourceRequestInfoImpl* ResourceLoader::GetRequestInfo() { 242 ResourceRequestInfoImpl* ResourceLoader::GetRequestInfo() {
241 return ResourceRequestInfoImpl::ForRequest(request_.get()); 243 return ResourceRequestInfoImpl::ForRequest(request_.get());
242 } 244 }
243 245
244 void ResourceLoader::ClearLoginDelegate() { 246 void ResourceLoader::ClearLoginDelegate() {
245 login_delegate_ = NULL; 247 login_delegate_ = NULL;
246 } 248 }
247 249
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 } 716 }
715 717
716 UMA_HISTOGRAM_ENUMERATION("Net.Prefetch.Pattern", status, STATUS_MAX); 718 UMA_HISTOGRAM_ENUMERATION("Net.Prefetch.Pattern", status, STATUS_MAX);
717 } else if (request_->response_info().unused_since_prefetch) { 719 } else if (request_->response_info().unused_since_prefetch) {
718 TimeDelta total_time = base::TimeTicks::Now() - request_->creation_time(); 720 TimeDelta total_time = base::TimeTicks::Now() - request_->creation_time();
719 UMA_HISTOGRAM_TIMES("Net.Prefetch.TimeSpentOnPrefetchHit", total_time); 721 UMA_HISTOGRAM_TIMES("Net.Prefetch.TimeSpentOnPrefetchHit", total_time);
720 } 722 }
721 } 723 }
722 724
723 } // namespace content 725 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/resource_loader.h ('k') | content/browser/loader/resource_request_info_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698