src/runtime/runtime-object.cc - Issue 2321533003: Properly handle holes following spreads in array literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 2321533003: Properly handle holes following spreads in array literals (Closed)

Patch Set: Less auto Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index 6d4bad5c6f889e5f0f833c648a1db335eb10cd0b..7908c6295ce082e5412f16f19d1a57ed2c9ff330 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -418,6 +418,7 @@ RUNTIME_FUNCTION(Runtime_AppendElement) {

CONVERT_ARG_HANDLE_CHECKED(JSArray, array, 0);

CONVERT_ARG_HANDLE_CHECKED(Object, value, 1);

+ CHECK(!value->IsTheHole(isolate));

uint32_t index;

CHECK(array->length()->ToArrayIndex(&index));

« no previous file with comments | « src/parsing/parser.cc ('k') | test/mjsunit/regress/regress-crbug-644215.js » ('j') | no next file with comments »