Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2321473003: Fix BytesConsumer::read (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BytesConsumer::read *readSize should be set to zero when returning errors. BUG=610195 Committed: https://crrev.com/5119566686b8fd231f014559d37027e20a9b42ac Cr-Commit-Position: refs/heads/master@{#418281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
yhirano
4 years, 3 months ago (2016-09-07 11:21:50 UTC) #4
hiroshige
lgtm. In general, the test coverage for the case where endRead() returns non-Ok is quite ...
4 years, 3 months ago (2016-09-07 13:02:59 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2269953004 Patch 200001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-07 13:23:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321473003/1
4 years, 3 months ago (2016-09-13 15:58:20 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 17:17:18 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 17:18:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5119566686b8fd231f014559d37027e20a9b42ac
Cr-Commit-Position: refs/heads/master@{#418281}

Powered by Google App Engine
This is Rietveld 408576698