[wasm] Call the wasm interpreter from the wasm-code-fuzzer.

[wasm] Call the wasm interpreter from the wasm-code-fuzzer.

With this CL the wasm-code-fuzzer first decodes and interprets the test
case generated by the fuzzer. It then compiles the test case, but only
executes the compiled instance if the interpretation of the test case
was successful. If the compiled instance is executed, then the result of
the execution is compared with the result of the interpretation.

Additionally this CL refactors the CompileAndRunWasmModule function in
wasm-module.cc to resuse code in the call to the interpreter.

R=titzer@chromium.org

Committed: https://crrev.com/1521fe9c3c88128cea5188b28068736a87838f1c
Cr-Commit-Position: refs/heads/master@{#39351}

[ahaas, 2016-09-07 09:45:13]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 09:45:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-07 09:56:59]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 09:57:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-07 09:58:07]

Changed the result comparison in the case of a trap, because the interpreter
traps differently than the compiled code.

[commit-bot: I haz the power, 2016-09-07 10:10:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 10:10:20]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12292)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[ahaas, 2016-09-07 10:32:59]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 10:33:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 11:17:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 11:17:05]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-09-09 08:58:59]

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:1725: int32_t CompileAndRunWasmModule(Isolate* isolate,
const byte* module_start,
I'm wondering if it's time to move this into the testing directory, since we
shouldn't be calling this anymore from production code.

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:14: #include "src/wasm/wasm-interpreter.h"
If you move the one function, then I think you can remove this include.

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:446: int32_t InterpretWasmModule(Isolate* isolate,
ErrorThrower& thrower,
Move this method to wasm-interpreter.h?

[ahaas, 2016-09-09 11:44:49]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 11:44:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 11:48:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 11:48:22]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[ahaas, 2016-09-09 11:56:30]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 11:56:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-09 11:57:34]

ahaas@chromium.org changed reviewers:
+ machenbach@chromium.org

[ahaas, 2016-09-09 11:57:36]

machenbach, could you take a look at the gn and gyp files?

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:1725: int32_t CompileAndRunWasmModule(Isolate* isolate,
const byte* module_start,
On 2016/09/09 at 08:58:59, titzer wrote:
> I'm wondering if it's time to move this into the testing directory, since we
shouldn't be calling this anymore from production code.

I created new files for this testing code in test/cctest/wasm/

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:14: #include "src/wasm/wasm-interpreter.h"
On 2016/09/09 at 08:58:59, titzer wrote:
> If you move the one function, then I think you can remove this include.

Removed.

https://codereview.chromium.org/2321443002/diff/40001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:446: int32_t InterpretWasmModule(Isolate* isolate,
ErrorThrower& thrower,
On 2016/09/09 at 08:58:59, titzer wrote:
> Move this method to wasm-interpreter.h?

I moved the code to the new file test/cctest/wasm/wasm-module-runner.h

[commit-bot: I haz the power, 2016-09-09 12:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 12:23:54]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-09-09 12:43:27]

gyp + gn lgtm

[titzer, 2016-09-12 11:46:21]

lgtm

https://codereview.chromium.org/2321443002/diff/80001/test/fuzzer/wasm-code.cc
File test/fuzzer/wasm-code.cc (right):

https://codereview.chromium.org/2321443002/diff/80001/test/fuzzer/wasm-code.c...
test/fuzzer/wasm-code.cc:56: v8::internal::wasm::ErrorThrower
interpreter_thrower(i_isolate,
Nit: use a "using v8::internal::wasm" to shorten this code a bit?

[ahaas, 2016-09-12 11:59:25]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 11:59:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-12 11:59:40]

The CQ bit was unchecked by ahaas@chromium.org

[ahaas, 2016-09-12 11:59:43]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-09-12 11:59:43]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2321443002/#ps100001
(title: "Address comments")

[commit-bot: I haz the power, 2016-09-12 11:59:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 12:26:41]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-12 12:26:54]

Description was changed from

==========
[wasm] Call the wasm interpreter from the wasm-code-fuzzer.

With this CL the wasm-code-fuzzer first decodes and interprets the test
case generated by the fuzzer. It then compiles the test case, but only
executes the compiled instance if the interpretation of the test case
was successful. If the compiled instance is executed, then the result of
the execution is compared with the result of the interpretation.

Additionally this CL refactors the CompileAndRunWasmModule function in
wasm-module.cc to resuse code in the call to the interpreter.

R=titzer@chromium.org
==========

to

==========
[wasm] Call the wasm interpreter from the wasm-code-fuzzer.

With this CL the wasm-code-fuzzer first decodes and interprets the test
case generated by the fuzzer. It then compiles the test case, but only
executes the compiled instance if the interpretation of the test case
was successful. If the compiled instance is executed, then the result of
the execution is compared with the result of the interpretation.

Additionally this CL refactors the CompileAndRunWasmModule function in
wasm-module.cc to resuse code in the call to the interpreter.

R=titzer@chromium.org

Committed: https://crrev.com/1521fe9c3c88128cea5188b28068736a87838f1c
Cr-Commit-Position: refs/heads/master@{#39351}
==========

[commit-bot: I haz the power, 2016-09-12 12:26:55]

Patchset 6 (id:??) landed as
https://crrev.com/1521fe9c3c88128cea5188b28068736a87838f1c
Cr-Commit-Position: refs/heads/master@{#39351}