Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/base/debug/stack_trace.cc

Issue 2321433003: Fix build on Solaris and musl-based platforms (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/base/debug/stack_trace_posix.cc » ('j') | src/base/debug/stack_trace_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/debug/stack_trace.cc
diff --git a/src/base/debug/stack_trace.cc b/src/base/debug/stack_trace.cc
index 0a7a3f9ab99f9fa5e6fb26313920e74a386cba44..bcd66b0b18a489ef5ad5e94b461d1474a720c531 100644
--- a/src/base/debug/stack_trace.cc
+++ b/src/base/debug/stack_trace.cc
@@ -31,7 +31,9 @@ const void* const* StackTrace::Addresses(size_t* count) const {
std::string StackTrace::ToString() const {
std::stringstream stream;
+#if V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS
rmcilroy 2016/09/07 11:06:22 This will avoid printing on windows also which is
targos 2016/09/12 07:34:53 Would adding "|| V8_OS_WIN" be enough for Windows
OutputToStream(&stream);
+#endif
return stream.str();
}
« no previous file with comments | « no previous file | src/base/debug/stack_trace_posix.cc » ('j') | src/base/debug/stack_trace_posix.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698