Fix build on Solaris and musl-based platforms

src/base/debug/stack_trace.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/base/debug/stack_trace.h"
 
 #include <string.h>
 
 #include <algorithm>
 #include <sstream>
@@ skipping 13 matching lines @@
 StackTrace::~StackTrace() {}
 
 const void* const* StackTrace::Addresses(size_t* count) const {
   *count = count_;
   if (count_) return trace_;
   return NULL;
 }
 
 std::string StackTrace::ToString() const {
   std::stringstream stream;
+#if V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS

[rmcilroy, 2016/09/07 11:06:22]

This will avoid printing on windows also which is wrong. The corresponding
change in Chromium is "#if !defined(__UCLIBC__)". Do you even need this though
(the CL mentions Solaris, and this change allows suggests Solaris can call
OutputToStream anyway.

[targos, 2016/09/12 07:34:53]

Would adding "|| V8_OS_WIN" be enough for Windows ?

   OutputToStream(&stream);
+#endif
   return stream.str();
 }
 
 }  // namespace debug
 }  // namespace base
 }  // namespace v8