third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html - Issue 2321363002: Custom Elements: layout tests for custom built-in elements definition

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html

Issue 2321363002: Custom Elements: layout tests for custom built-in elements definition (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Custom Elements: defineElement</title>	2 <title>Custom Elements: defineElement</title>

3 <link rel="help" href="https://html.spec.whatwg.org/multipage/scripting.html#cus tomelementsregistry">	3 <link rel="help" href="https://html.spec.whatwg.org/multipage/scripting.html#cus tomelementsregistry">

4 <meta name="author" title="Dominic Cooney" href="mailto:dominicc@chromium.org">	4 <meta name="author" title="Dominic Cooney" href="mailto:dominicc@chromium.org">

5 <script src="../../resources/testharness.js"></script>	5 <script src="../../resources/testharness.js"></script>

6 <script src="../../resources/testharnessreport.js"></script>	6 <script src="../../resources/testharnessreport.js"></script>

7 <script src="resources/custom-elements-helpers.js"></script>	7 <script src="resources/custom-elements-helpers.js"></script>

8 <body>	8 <body>

9 <script>	9 <script>

10 // TODO(dominicc): Merge these tests with	10 // TODO(dominicc): Merge these tests with

(...skipping 84 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
95 w1.customElements.define('first-name', X);	95 w1.customElements.define('first-name', X);

96 w2.customElements.define('second-name', X);	96 w2.customElements.define('second-name', X);

97 assert_equals(	97 assert_equals(

98 new X().localName, 'second-name',	98 new X().localName, 'second-name',

99 'the current global object should determine which definition is ' +	99 'the current global object should determine which definition is ' +

100 'operative; because X extends w2.HTMLElement, w2 is operative');	100 'operative; because X extends w2.HTMLElement, w2 is operative');

101 });	101 });

102 }, 'HTMLElement constructor looks up definitions in the current global-' +	102 }, 'HTMLElement constructor looks up definitions in the current global-' +

103 'reused constructor');	103 'reused constructor');

104	104

	105 // TODO: What error should be thrown if extends option not specified or null?
	dominicc (has gone to gerrit) 2016/09/12 05:12:54 Part of it is element definition [1] step 6. If th Part of it is element definition [1] step 6. If the option is not specified then _extends_ is null. Step 7 skips stuff if that's the case. Then there's the question of what to do if extends is specified, but null or undefined. This is a bit more subtle. Because ElementRegistrationOptions is a Dictionary a lot of its handling is specified in Web IDL, especially the EcmaScript binding [2]. You see the values are copied out of the argument into the dictionary in step 5.1.3.2, but undefined and null are filtered in step 5.1.2-3. So null and undefined also end up missing from the dictionary and step 7 is skipped for them, too. [1] https://html.spec.whatwg.org/#element-definition [2] https://heycam.github.io/webidl/#es-dictionary
	106

	107 test_with_window((w) => {

	108 class A extends w.HTMLButtonElement {}

	109 let invalid_values = [
	kojii 2016/09/12 04:52:23 Let's make the variable name more explicit; in thi Let's make the variable name more explicit; in this case this is a list of "valid custom element name", correct?
	110 'a-a',

	111 'z0-y0',

	112 'emotion-\u1f60d',

	113 'math-\u03b1',

	114 'a.b-c'

	115 ];

	116 invalid_values.forEach((val) => {

	117 assert_throws_dom_exception(w, 'NotSupportedError', () => {

	118 w.customElements.define('a-a', A, { extends: val });

	119 }, 'extends value must not be valid customized element name')
	dominicc (has gone to gerrit) 2016/09/12 05:12:54 It might be good to include the actual value in th It might be good to include the actual value in the failure message to make it easy to understand which case is failing.
	120 });

	121 }, 'Invalid extends value');
	dominicc (has gone to gerrit) 2016/09/12 05:12:54 This and the next test may show up in output like This and the next test may show up in output like PASS Invalid extends value FAIL Invalid extends value which isn't very illuminating. They're different tests, so briefly describe the difference: mention potential custom element names and names of elements whose interface is HTMLUnknown element so people looking at the test output have an high-level idea what each test is doing.
	122

	123 test_with_window((w) => {

	124 class A extends w.HTMLButtonElement {}

	125 let invalid_values = [
	kojii 2016/09/12 04:52:23 ditto; such as "element_names_for_HTMLUnknownEleme ditto; such as "element_names_for_HTMLUnknownElement" or such.
	126 'bgsound',

	127 'blink',

	128 'isindex',

	129 'multicol',

	130 'nextid',

	131 'spacer',

	132 42

	133 ]

	134 invalid_values.forEach((val) => {

	135 assert_throws_dom_exception(w, 'NotSupportedError', () => {

	136 w.customElements.define('a-a', A, { extends: val });

	137 }, 'extends value cannot be HTMLUnknownElement');
	dominicc (has gone to gerrit) 2016/09/12 05:12:55 Make this more precise; the value isn't HTMLUnknow Make this more precise; the value isn't HTMLUnknownElement but a string; I think the spec text calls the thing you're interested in the "element interface for extends"? Briefly paraphrase it for the test. BTW it's a common challenge in these tests to be testing some concept in the spec that has a different name or is only available implicitly in the API. Try to balance brevity, precision, readability. When all else fails cutting and pasting lines from the spec to cite it directly, and make variable names match spec terms, is a safe way to go.
	138 });

	139 }, 'Invalid extends value');

	140

	141 test_with_window((w) => {

	142 class A extends w.HTMLButtonElement {}

	143 w.customElements.define('defined-name', A, { extends: 'button'});
	dominicc (has gone to gerrit) 2016/09/12 05:12:54 Be consistent with spacing; you put a space before Be consistent with spacing; you put a space before } above but not here. It may be more succinct without spaces after {/before } for object literals.
	144 assert_equals(new A().localName, 'button', 'extends value should == local ' +
	kojii 2016/09/12 04:52:23 Let's make human text; such as "localName should b Let's make human text; such as "localName should be extends". dominicc (has gone to gerrit) 2016/09/12 05:12:54 Use English, so not == but just 'be' or something Use English, so not == but just 'be' or something like that. When wrapping, wrap at a higher-level expression if it results in the same number of line breaks. In this case, you can probably put the whole string on one line by wrapping after , and then you don't need the ' + ' either which is simpler anyway.
	145 'name');

	146 assert_not_equals(new A().localName, 'defined-name', 'extends value ' +
	kojii 2016/09/12 04:52:23 ditto. ditto.
	147 'should != defined-name');

	148 }, 'Localname should be extends value not defined-name');
	dominicc (has gone to gerrit) 2016/09/12 05:12:54 Write 'Local name ...' with a space. localName is Write 'Local name ...' with a space. localName is OK when you need to refer to that specific API, but then match the case.
	149

105 promise_test((t) => {	150 promise_test((t) => {

106 return Promise.all([create_window_in_test(t), create_window_in_test(t)])	151 return Promise.all([create_window_in_test(t), create_window_in_test(t)])

107 .then(([w1, w2]) => {	152 .then(([w1, w2]) => {

108 class X extends w2.HTMLElement { };	153 class X extends w2.HTMLElement { };

109 w1.customElements.define('x-x', X);	154 w1.customElements.define('x-x', X);

110 assert_throws(	155 assert_throws(

111 TypeError.prototype, () => new X(),	156 TypeError.prototype, () => new X(),

112 'the current global object (w2) should not find the definition in w1');	157 'the current global object (w2) should not find the definition in w1');

113 });	158 });

114 }, 'HTMLElement constructor looks up definitions in the current global');	159 }, 'HTMLElement constructor looks up definitions in the current global');

(...skipping 288 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
403 // step 2	448 // step 2

404 test_with_window((w) => {	449 test_with_window((w) => {

405 let invalid_name = 'annotation-xml';	450 let invalid_name = 'annotation-xml';

406 assert_throws_dom_exception(w, 'SYNTAX_ERR', () => {	451 assert_throws_dom_exception(w, 'SYNTAX_ERR', () => {

407 w.customElements.define(invalid_name, class extends HTMLElement {});	452 w.customElements.define(invalid_name, class extends HTMLElement {});

408 }, 'defining author-defined custom element constructor should pass this ' +	453 }, 'defining author-defined custom element constructor should pass this ' +

409 'step without throwing TypeError');	454 'step without throwing TypeError');

410 }, 'Invalid constructor');	455 }, 'Invalid constructor');

411 </script>	456 </script>

412 </body>	457 </body>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/custom-elements/spec/define-element-expected.txt » ('j') | no next file with comments »