Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2321333002: Translate the clip rect correctly when iterating over fragmentainers. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Translate the clip rect correctly when iterating over fragmentainers. The clip rect is visual, so we need to shift each fragmentainer group by its visual translation. This matters for nested multicol. BUG=642325 Committed: https://crrev.com/4a0e7885bc0bb78310c2016901f438588b483e42 Cr-Commit-Position: refs/heads/master@{#417563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-clipped-first-column.html View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/multicol/nested-with-clipped-first-column-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
Note that this is an old bug that doesn't have anything to do with the ...
4 years, 3 months ago (2016-09-09 11:44:40 UTC) #6
eae
LGTM
4 years, 3 months ago (2016-09-09 12:19:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321333002/1
4 years, 3 months ago (2016-09-09 12:20:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 12:24:03 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 12:26:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a0e7885bc0bb78310c2016901f438588b483e42
Cr-Commit-Position: refs/heads/master@{#417563}

Powered by Google App Engine
This is Rietveld 408576698