Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 232133008: DevTools: Make replace checkbox id in SearchableView unique. (Closed)

Created:
6 years, 8 months ago by vsevik
Modified:
6 years, 8 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Make replace checkbox id in SearchableView unique. Otherwise clicking on the checkbox label is processed incorrectly when searchable view is opened on different panels. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171328

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M LayoutTests/inspector/editor/text-editor-search-replace.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/SearchableView.js View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
vsevik
PTAL
6 years, 8 months ago (2014-04-10 15:37:12 UTC) #1
apavlov
lgtm provided that there are no CSS styles involved with this id
6 years, 8 months ago (2014-04-11 07:19:59 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 8 months ago (2014-04-11 08:26:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/232133008/1
6 years, 8 months ago (2014-04-11 08:26:31 UTC) #4
vsevik
The CQ bit was unchecked by vsevik@chromium.org
6 years, 8 months ago (2014-04-11 08:27:02 UTC) #5
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 8 months ago (2014-04-11 08:28:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/232133008/20001
6 years, 8 months ago (2014-04-11 08:28:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 08:43:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-11 08:43:05 UTC) #9
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 8 months ago (2014-04-11 09:22:03 UTC) #10
vsevik
The CQ bit was unchecked by vsevik@chromium.org
6 years, 8 months ago (2014-04-11 09:22:04 UTC) #11
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 8 months ago (2014-04-11 09:22:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/232133008/20001
6 years, 8 months ago (2014-04-11 09:22:18 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 09:22:43 UTC) #14
Message was sent while issue was closed. 
Change committed as 171328

Powered by Google App Engine
This is Rietveld 408576698