Source/core/rendering/style/RenderStyle.cpp - Issue 232133006: Modified to function QuotesData::equals() function to use operator overloading operator== for easy …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 232133006: Modified to function QuotesData::equals() function to use operator overloading operator== for easy … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/style/QuotesData.cpp ('K') | « Source/core/rendering/style/QuotesData.cpp ('k') | Source/core/rendering/style/StyleRareInheritedData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/style/RenderStyle.cpp

diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp

index 274f75d7cd8537ac7ef232be85b8bb07f46bab04..f9120b6b64bb8da0eb2d6d7ef906c64fe0905176 100644

--- a/Source/core/rendering/style/RenderStyle.cpp

+++ b/Source/core/rendering/style/RenderStyle.cpp

@@ -506,7 +506,7 @@ StyleDifference RenderStyle::visualInvalidationDiff(const RenderStyle& other, un

if (!rareInheritedData->shadowDataEquivalent(*other.rareInheritedData.get()))

return StyleDifferenceLayout;

- if (!QuotesData::equals(rareInheritedData->quotes.get(), other.rareInheritedData->quotes.get()))

+ if (!(*rareInheritedData->quotes.get() == *other.rareInheritedData->quotes.get()))

return StyleDifferenceLayout;

}

@@ -697,7 +697,7 @@ void RenderStyle::setCursorList(PassRefPtr<CursorList> other)

void RenderStyle::setQuotes(PassRefPtr<QuotesData> q)

{

- if (QuotesData::equals(rareInheritedData->quotes.get(), q.get()))

+ if (*rareInheritedData->quotes.get() == *q.get())

return;

rareInheritedData.access()->quotes = q;

}