Source/core/rendering/style/QuotesData.h - Issue 232133006: Modified to function QuotesData::equals() function to use operator overloading operator== for easy …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/QuotesData.h

Issue 232133006: Modified to function QuotesData::equals() function to use operator overloading operator== for easy … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/style/QuotesData.h

diff --git a/Source/core/rendering/style/QuotesData.h b/Source/core/rendering/style/QuotesData.h

index 94e89e37e104c2173e9679d75e67e9fe59a6d992..c16d3cd54bb8e3b9e1ece097ef226bfdde04f75a 100644

--- a/Source/core/rendering/style/QuotesData.h

+++ b/Source/core/rendering/style/QuotesData.h

@@ -35,8 +35,7 @@ public:

static PassRefPtr<QuotesData> create(const String open, const String close);

static PassRefPtr<QuotesData> create(UChar open1, UChar close1, UChar open2, UChar close2);

- // FIXME: this should be an operator==.

- static bool equals(const QuotesData*, const QuotesData*);

+ bool operator==(const QuotesData&);

void addPair(const std::pair<String, String> quotePair);

const String getOpenQuote(int index) const;

« no previous file with comments | « no previous file | Source/core/rendering/style/QuotesData.cpp » ('j') | Source/core/rendering/style/QuotesData.cpp » ('J')