Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 232133006: Modified to function QuotesData::equals() function to use operator overloading operator== for easy … (Closed)

Created:
6 years, 8 months ago by patro
Modified:
6 years, 8 months ago
Reviewers:
Sikugu_, vivekg, esprehn, apavlov
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Modified to function QuotesData::equals() function to use operator overloading operator== for easy usage Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171541

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch Set 2 #

Total comments: 1

Patch Set 3 : Patch Set 3 #

Patch Set 4 : Patch Set 4 #

Patch Set 5 : Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M Source/core/rendering/style/QuotesData.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/QuotesData.cpp View 1 2 3 4 1 chunk +7 lines, -6 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
Sikugu_
https://codereview.chromium.org/232133006/diff/1/Source/core/rendering/style/QuotesData.cpp File Source/core/rendering/style/QuotesData.cpp (right): https://codereview.chromium.org/232133006/diff/1/Source/core/rendering/style/QuotesData.cpp#newcode69 Source/core/rendering/style/QuotesData.cpp:69: return this->m_quotePairs == a.m_quotePairs; you can use m_quotePairs directly ...
6 years, 8 months ago (2014-04-10 15:08:00 UTC) #1
patro
https://codereview.chromium.org/232133006/diff/1/Source/core/rendering/style/QuotesData.cpp File Source/core/rendering/style/QuotesData.cpp (right): https://codereview.chromium.org/232133006/diff/1/Source/core/rendering/style/QuotesData.cpp#newcode69 Source/core/rendering/style/QuotesData.cpp:69: return this->m_quotePairs == a.m_quotePairs; On 2014/04/10 15:08:00, Sikugu_ wrote: ...
6 years, 8 months ago (2014-04-11 05:00:22 UTC) #2
patro
Please review
6 years, 8 months ago (2014-04-11 15:22:47 UTC) #3
esprehn
lgtm, please remove empty BUG= lines in the future. Add != operator and fix nit ...
6 years, 8 months ago (2014-04-11 17:50:28 UTC) #4
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 8 months ago (2014-04-14 05:23:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/232133006/40001
6 years, 8 months ago (2014-04-14 05:23:37 UTC) #6
patro
The CQ bit was unchecked by behara.ms@samsung.com
6 years, 8 months ago (2014-04-14 05:23:38 UTC) #7
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 8 months ago (2014-04-14 05:26:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/232133006/40001
6 years, 8 months ago (2014-04-14 05:26:15 UTC) #9
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 8 months ago (2014-04-14 05:26:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/232133006/40001
6 years, 8 months ago (2014-04-14 05:26:30 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 05:37:07 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-14 05:37:08 UTC) #13
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 8 months ago (2014-04-14 09:29:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/232133006/40001
6 years, 8 months ago (2014-04-14 09:29:33 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 09:39:31 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-14 09:39:31 UTC) #17
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 8 months ago (2014-04-15 06:15:17 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/232133006/60001
6 years, 8 months ago (2014-04-15 06:15:36 UTC) #19
patro
The CQ bit was unchecked by behara.ms@samsung.com
6 years, 8 months ago (2014-04-15 06:15:44 UTC) #20
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 8 months ago (2014-04-15 06:18:35 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/232133006/80001
6 years, 8 months ago (2014-04-15 06:19:02 UTC) #22
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 07:25:24 UTC) #23
Message was sent while issue was closed. 
Change committed as 171541

Powered by Google App Engine
This is Rietveld 408576698