Issue 232133005: ozone: Protect X11-specific code under ash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232133005: ozone: Protect X11-specific code under ash (Closed)

Created:
6 years, 8 months ago by spang

Modified:
6 years, 8 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ozone: Protect X11-specific code under chrome/browser/ui/ash This fixes some build errors for the "chromeos=1 use_ozone=1" build. The code under ash/accelerators is currently only supported under X11. BUG=361341 TEST=chrome --ozone-platform=test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262923

Patch Set 1 #

Patch Set 2 : rebase, one more X11 line showed up #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
M	ash/accelerators/accelerator_dispatcher_linux.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/ash_init.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

spang

On 2014/04/09 23:50:10, Daniel Erat wrote: > lgtm fyi, another line showed up in accelerator_dispatcher_linux.cc

6 years, 8 months ago (2014-04-10 00:04:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/232133005/10003

6 years, 8 months ago (2014-04-10 00:14:22 UTC) #5

Message was sent while issue was closed.

Change committed as 262923

Expand Messages | Collapse Messages