Split WebLocalFrame into a distinct subclass of WebFrame.

Split WebLocalFrame into a distinct subclass of WebFrame.

This also moves a few static methods that don't make sense on WebFrame
to WebLocalFrame.

BUG=346764
R=eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171396

[dcheng, 2014-04-09 23:14:14]

After this, we can start moving APIs off WebFrame, as well as land initial stubs
for WebRemoteFrame so we can start implementing the logic to swap from local to
remote, etc.

[dcheng, 2014-04-09 23:14:58]

Note that this can't land until 1-2 more cleanup CLs land in Chrome, but the
patch itself should be ready for review.

[eseidel, 2014-04-10 00:40:10]

https://codereview.chromium.org/232133004/diff/1/Source/web/WebFrameImpl.h
File Source/web/WebFrameImpl.h (right):

https://codereview.chromium.org/232133004/diff/1/Source/web/WebFrameImpl.h#ne...
Source/web/WebFrameImpl.h:34: #include "WebLocalFrame.h"
Are you sure you want this?

[dcheng, 2014-04-10 00:50:32]

https://codereview.chromium.org/232133004/diff/1/Source/web/WebFrameImpl.h
File Source/web/WebFrameImpl.h (right):

https://codereview.chromium.org/232133004/diff/1/Source/web/WebFrameImpl.h#ne...
Source/web/WebFrameImpl.h:34: #include "WebLocalFrame.h"
On 2014/04/10 00:40:10, eseidel wrote:
> Are you sure you want this?

I believe so. WebFrameImpl is going to morph into WebLocalFrameImpl.

[dcheng, 2014-04-10 23:03:27]

eseidel: ping?

Also +isherman. I've added some basic comments to WebLocalFrame and WebFrame.
I'm not the best at comments though, so any suggestions/feedback here would be
welcome.

[eseidel, 2014-04-11 16:52:15]

lgtm

[commit-bot: I haz the power, 2014-04-11 16:52:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/232133004/1

[dcheng, 2014-04-11 16:52:42]

The CQ bit was unchecked by dcheng@chromium.org

[Ilya Sherman, 2014-04-11 23:02:53]

On 2014/04/10 23:03:27, dcheng wrote:
> Also +isherman. I've added some basic comments to WebLocalFrame and WebFrame.
> I'm not the best at comments though, so any suggestions/feedback here would be
> welcome.

Hmm, where did you add the comments?  I'm not seeing any class-level comments in
this CL.  Am I just overlooking them?

[dcheng, 2014-04-11 23:07:08]

On 2014/04/11 23:02:53, Ilya Sherman wrote:
> On 2014/04/10 23:03:27, dcheng wrote:
> > Also +isherman. I've added some basic comments to WebLocalFrame and
WebFrame.
> > I'm not the best at comments though, so any suggestions/feedback here would
be
> > welcome.
> 
> Hmm, where did you add the comments?  I'm not seeing any class-level comments
in
> this CL.  Am I just overlooking them?

Uh. They're... on my local git branch.

Uploaded.

[dcheng, 2014-04-12 05:51:02]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-04-12 05:51:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/232133004/20001

[commit-bot: I haz the power, 2014-04-12 06:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-12 06:35:00]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_compile_dbg

[dcheng, 2014-04-12 08:31:04]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-04-12 08:31:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/232133004/40001

[commit-bot: I haz the power, 2014-04-12 09:10:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-12 09:10:14]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[dcheng, 2014-04-12 09:55:36]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-04-12 09:55:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/232133004/40001

[dcheng, 2014-04-12 10:25:15]

Committed patchset #3 manually as r171396 (tree was closed).