Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 2321313002: Move components/memory_coordinator -> content/ (Closed)

Created:
4 years, 3 months ago by bashi
Modified:
4 years, 3 months ago
Reviewers:
haraken, tasak, jam, chrisha, dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), hajimehoshi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move components/memory_coordinator -> content/ Basically, - components/memory_coordinator/public/interfaces -> content/common - components/memory_coordinator/common -> content/common - components/memory_coordinator/browser -> content/browser - components/memory_coordinator/child -> content/child BUG=644022 Committed: https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3 Cr-Commit-Position: refs/heads/master@{#418783}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase etc #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -1713 lines) Patch
M components/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
D components/memory_coordinator/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/memory_coordinator/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/memory_coordinator/browser/BUILD.gn View 1 1 chunk +0 lines, -46 lines 0 comments Download
D components/memory_coordinator/browser/memory_coordinator.h View 1 chunk +0 lines, -91 lines 0 comments Download
D components/memory_coordinator/browser/memory_coordinator.cc View 1 chunk +0 lines, -125 lines 0 comments Download
D components/memory_coordinator/browser/memory_coordinator_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D components/memory_coordinator/browser/memory_monitor.h View 1 1 chunk +0 lines, -58 lines 0 comments Download
D components/memory_coordinator/browser/memory_monitor.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
D components/memory_coordinator/browser/memory_monitor_linux.h View 1 1 chunk +0 lines, -38 lines 0 comments Download
D components/memory_coordinator/browser/memory_monitor_linux.cc View 1 1 chunk +0 lines, -54 lines 1 comment Download
D components/memory_coordinator/browser/memory_monitor_linux_unittest.cc View 1 1 chunk +0 lines, -77 lines 0 comments Download
D components/memory_coordinator/browser/memory_monitor_win.h View 1 1 chunk +0 lines, -65 lines 0 comments Download
D components/memory_coordinator/browser/memory_monitor_win.cc View 1 1 chunk +0 lines, -79 lines 0 comments Download
D components/memory_coordinator/browser/memory_monitor_win_unittest.cc View 1 1 chunk +0 lines, -138 lines 0 comments Download
D components/memory_coordinator/browser/test_memory_monitor.h View 1 1 chunk +0 lines, -38 lines 0 comments Download
D components/memory_coordinator/browser/test_memory_monitor.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
D components/memory_coordinator/child/BUILD.gn View 1 chunk +0 lines, -39 lines 0 comments Download
D components/memory_coordinator/child/child_memory_coordinator_impl.h View 1 chunk +0 lines, -63 lines 0 comments Download
D components/memory_coordinator/child/child_memory_coordinator_impl.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D components/memory_coordinator/child/child_memory_coordinator_impl_android.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/memory_coordinator/child/child_memory_coordinator_impl_android.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D components/memory_coordinator/child/child_memory_coordinator_impl_unittest.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D components/memory_coordinator/common/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D components/memory_coordinator/common/memory_coordinator_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D components/memory_coordinator/common/memory_coordinator_features.h View 1 chunk +0 lines, -25 lines 0 comments Download
D components/memory_coordinator/common/memory_coordinator_features.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D components/memory_coordinator/public/interfaces/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D components/memory_coordinator/public/interfaces/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom View 1 1 chunk +0 lines, -23 lines 0 comments Download
D components/memory_coordinator/public/interfaces/memory_coordinator.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 chunks +8 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
A + content/browser/memory/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/memory/memory_coordinator.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + content/browser/memory/memory_coordinator.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/memory/memory_coordinator_browsertest.cc View 1 chunk +17 lines, -9 lines 0 comments Download
A + content/browser/memory/memory_coordinator_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + content/browser/memory/memory_monitor.h View 1 3 chunks +14 lines, -10 lines 0 comments Download
A + content/browser/memory/memory_monitor.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download
A + content/browser/memory/memory_monitor_linux.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
A + content/browser/memory/memory_monitor_linux.cc View 1 3 chunks +6 lines, -8 lines 0 comments Download
A + content/browser/memory/memory_monitor_linux_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/memory/memory_monitor_win.h View 1 2 chunks +21 lines, -8 lines 0 comments Download
A + content/browser/memory/memory_monitor_win.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/memory/memory_monitor_win_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/memory/test_memory_monitor.h View 1 2 chunks +8 lines, -3 lines 0 comments Download
A + content/browser/memory/test_memory_monitor.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 4 chunks +5 lines, -6 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A + content/child/memory/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/child/memory/child_memory_coordinator_impl.h View 3 chunks +11 lines, -12 lines 0 comments Download
A + content/child/memory/child_memory_coordinator_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/memory/child_memory_coordinator_impl_android.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/child/memory/child_memory_coordinator_impl_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/memory/child_memory_coordinator_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + content/common/child_memory_coordinator.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/common/memory_coordinator.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 4 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 3 chunks +6 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (13 generated)
bashi
PTAL? jam@: content/ haraken@, chrisha@: component/memory_coordinator tasak@: FYI This CL depends on https://codereview.chromium.org/2311723002/
4 years, 3 months ago (2016-09-09 01:46:56 UTC) #6
bashi
+dcheng@ for IPC (mojom) review
4 years, 3 months ago (2016-09-09 01:51:26 UTC) #8
haraken
LGTM
4 years, 3 months ago (2016-09-09 01:51:40 UTC) #9
dcheng
rs lgtm for mojom since this is just moving code
4 years, 3 months ago (2016-09-09 01:58:37 UTC) #10
jam
lgtm with comments https://codereview.chromium.org/2321313002/diff/1/content/browser/memory/memory_coordinator.h File content/browser/memory/memory_coordinator.h (right): https://codereview.chromium.org/2321313002/diff/1/content/browser/memory/memory_coordinator.h#newcode1 content/browser/memory/memory_coordinator.h:1: // Copyright 2016 The Chromium Authors. ...
4 years, 3 months ago (2016-09-09 16:06:54 UTC) #11
chrisha
On 2016/09/09 16:06:54, jam wrote: > lgtm with comments > > https://codereview.chromium.org/2321313002/diff/1/content/browser/memory/memory_coordinator.h > File content/browser/memory/memory_coordinator.h ...
4 years, 3 months ago (2016-09-09 19:16:11 UTC) #12
bashi
+hajimehoshi@ FYI. You will need to rebase your CL (https://codereview.chromium.org/2335933003/) The previous CL (https://codereview.chromium.org/2311723002/) is ...
4 years, 3 months ago (2016-09-15 04:44:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321313002/20001
4 years, 3 months ago (2016-09-15 04:44:45 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 04:50:13 UTC) #21
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3 Cr-Commit-Position: refs/heads/master@{#418783}
4 years, 3 months ago (2016-09-15 04:52:27 UTC) #23
bashi
4 years, 3 months ago (2016-09-15 04:55:09 UTC) #24
Message was sent while issue was closed.
(Forgot to reply comments...)

https://codereview.chromium.org/2321313002/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator.h (right):

https://codereview.chromium.org/2321313002/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator.h:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2016/09/09 16:06:54, jam wrote:
> move components/memory_coordinator/OWNERS to this directory as well to
maintain
> the owners

Done.

https://codereview.chromium.org/2321313002/diff/1/content/child/memory/child_...
File content/child/memory/child_memory_coordinator_impl.h (right):

https://codereview.chromium.org/2321313002/diff/1/content/child/memory/child_...
content/child/memory/child_memory_coordinator_impl.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2016/09/09 16:06:54, jam wrote:
> ditto re owners

Done.

Powered by Google App Engine
This is Rietveld 408576698