Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: components/variations/variations_params_manager.h

Issue 2321273003: Extend VariationParamsManager to support feature associations. (Closed)
Patch Set: Alexei's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_params_manager.h
diff --git a/components/variations/variations_params_manager.h b/components/variations/variations_params_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..436d36150872cfc656a77aba0eb3c16343d976e1
--- /dev/null
+++ b/components/variations/variations_params_manager.h
@@ -0,0 +1,76 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_VARIATIONS_VARIATIONS_PARAMS_MANAGER_H_
+#define COMPONENTS_VARIATIONS_VARIATIONS_PARAMS_MANAGER_H_
+
+#include <map>
+#include <memory>
+#include <string>
+
+#include "base/macros.h"
+#include "base/metrics/field_trial.h"
+
+namespace base {
+class FieldTrialList;
+
+namespace test {
+class ScopedFeatureList;
+} // namespace test
+
+} // namespace base
+
+namespace variations {
+
Alexei Svitkine (slow) 2016/09/12 16:54:13 Nit: Remove empty line
jkrcal 2016/09/23 13:40:09 Done.
+namespace testing {
+
+// Use this class as a member in your test class to set variation params for
+// your tests. You can directly set the parameters in the constructor (if they
+// are used by other members upon construction). You can change them later
+// arbitrarily many times using the SetVariationParams function. Internally, it
+// creates a FieldTrialList as a member. It works well for multiple tests of a
+// given test class, as it clears the parameters when this class is destructed.
+// Note that it clears all parameters (not just those registered here).
+class VariationParamsManager {
+ public:
+ // Does not associate any parameters.
+ VariationParamsManager();
+ // Calls directly SetVariationParams with the provided arguments.
+ VariationParamsManager(
+ const std::string& trial_name,
+ const std::map<std::string, std::string>& param_values,
+ const std::map<std::string, std::string>& param_features);
+ ~VariationParamsManager();
+
+ // Associates |param_values| with the given |trial_name|. |param_values| maps
+ // parameter names to their values. |param_features| maps parameter names to
+ // names of the features they should be associated with. The keys in
+ // |param_features| must be a subset of the keys in |param_values|
+ // (|param_features| may specify all the parameters, or only some, or even
+ // none). The function creates a new trial group, used only for testing.
+ // Between two calls of this function, ClearAllVariationParams() has to be
+ // called.
+ void SetVariationParams(
+ const std::string& trial_name,
+ const std::map<std::string, std::string>& param_values,
+ const std::map<std::string, std::string>& param_features);
+
+ // Clears all of the mapped associations.
+ void ClearAllVariationIDs();
+
+ // Clears all of the associated params.
+ void ClearAllVariationParams();
+
+ private:
+ std::unique_ptr<base::FieldTrialList> field_trial_list_;
+ std::unique_ptr<base::test::ScopedFeatureList> scoped_feature_list_;
+
+ DISALLOW_COPY_AND_ASSIGN(VariationParamsManager);
+};
+
+} // namespace testing
+
Alexei Svitkine (slow) 2016/09/12 16:54:13 Nit: Remove empty line
jkrcal 2016/09/23 13:40:09 Done.
+} // namespace variations
+
+#endif // COMPONENTS_VARIATIONS_VARIATIONS_PARAMS_MANAGER_H_

Powered by Google App Engine
This is Rietveld 408576698