Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Side by Side Diff: components/variations/variations_params_manager.cc

Issue 2321273003: Extend VariationParamsManager to support feature associations. (Closed)
Patch Set: Last comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/variations/variations_params_manager.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/variations/variations_params_manager.h"
6
7 #include <utility>
8
9 #include "base/feature_list.h"
10 #include "base/metrics/field_trial.h"
11 #include "base/test/scoped_feature_list.h"
12 #include "components/variations/variations_associated_data.h"
13
14 namespace variations {
15 namespace testing {
16
17 namespace {
18
19 // The fixed testing group created in the provided trail when setting up params.
20 const char kGroupTesting[] = "Testing";
21
22 base::FieldTrial* CreateFieldTrialWithParams(
23 const std::string& trial_name,
24 const std::map<std::string, std::string>& param_values) {
25 variations::AssociateVariationParams(trial_name, kGroupTesting, param_values);
26 return base::FieldTrialList::CreateFieldTrial(trial_name, kGroupTesting);
27 }
28
29 } // namespace
30
31 VariationParamsManager::VariationParamsManager()
32 : field_trial_list_(new base::FieldTrialList(nullptr)),
33 scoped_feature_list_(new base::test::ScopedFeatureList()) {}
34
35 VariationParamsManager::VariationParamsManager(
36 const std::string& trial_name,
37 const std::map<std::string, std::string>& param_values)
38 : VariationParamsManager() {
39 SetVariationParams(trial_name, param_values);
40 }
41
42 VariationParamsManager::VariationParamsManager(
43 const std::string& trial_name,
44 const std::map<std::string, std::string>& param_values,
45 const std::set<std::string>& associated_features)
46 : VariationParamsManager() {
47 SetVariationParamsWithFeatureAssociations(trial_name, param_values,
48 associated_features);
49 }
50
51 VariationParamsManager::~VariationParamsManager() {
52 ClearAllVariationIDs();
53 ClearAllVariationParams();
54 }
55
56 void VariationParamsManager::SetVariationParams(
57 const std::string& trial_name,
58 const std::map<std::string, std::string>& param_values) {
59 CreateFieldTrialWithParams(trial_name, param_values);
60 }
61
62 void VariationParamsManager::SetVariationParamsWithFeatureAssociations(
63 const std::string& trial_name,
64 const std::map<std::string, std::string>& param_values,
65 const std::set<std::string>& associated_features) {
66 base::FieldTrial* field_trial =
67 CreateFieldTrialWithParams(trial_name, param_values);
68
69 std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
70 for (const std::string& feature_name : associated_features) {
71 feature_list->RegisterFieldTrialOverride(
72 feature_name,
73 base::FeatureList::OverrideState::OVERRIDE_ENABLE_FEATURE,
74 field_trial);
75 }
76
77 scoped_feature_list_->InitWithFeatureList(std::move(feature_list));
78 }
79
80 void VariationParamsManager::ClearAllVariationIDs() {
81 variations::testing::ClearAllVariationIDs();
82 }
83
84 void VariationParamsManager::ClearAllVariationParams() {
85 variations::testing::ClearAllVariationParams();
86 // When the scoped feature list is destroyed, it puts back the original
87 // feature list that was there when InitWithFeatureList() was called.
88 scoped_feature_list_.reset(new base::test::ScopedFeatureList());
89 }
90
91 } // namespace testing
92 } // namespace variations
OLDNEW
« no previous file with comments | « components/variations/variations_params_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698