Extend VariationParamsManager to support feature associations.

chrome/browser/chromeos/hats/hats_finch_helper_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/hats/hats_finch_helper.h"
 
 #include <map>
+#include <set>
+#include <string>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/test/scoped_feature_list.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/prefs/pref_service.h"
 #include "components/variations/variations_associated_data.h"
+#include "components/variations/variations_params_manager.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 
 namespace {
 
-const char kGroupTesting[] = "Testing";
-const std::string kTrialName(features::kHappinessTrackingSystem.name);
+const std::string kFeatureAndTrialName(features::kHappinessTrackingSystem.name);
 
 }  // namespace
 
 class HatsFinchHelperTest : public testing::Test {
  public:
   using ParamMap = std::map<std::string, std::string>;
 
-  HatsFinchHelperTest() : params_manager_(kTrialName, {{}}) {}
-
-  void SetUp() override {
-    scoped_feature_list_.InitAndEnableFeature(
-        features::kHappinessTrackingSystem);
-  }
+  HatsFinchHelperTest() {}
 
   void SetFinchSeedParams(ParamMap params) {
-    // Clear all the things.
-    variations::testing::ClearAllVariationParams();
-    variations::testing::ClearAllVariationIDs();
-    variations::AssociateVariationParams(kTrialName, kGroupTesting, params);
+    params_manager_.SetVariationParamsWithFeatureAssociations(
+        kFeatureAndTrialName /* trial name */, params,
+        std::set<std::string>{kFeatureAndTrialName} /*features to switch on */);
   }
 
   ParamMap CreateParamMap(std::string prob,
                           std::string cycle_length,
                           std::string start_date,
                           std::string reset_survey,
                           std::string reset) {
     ParamMap params;
     params[HatsFinchHelper::kProbabilityParam] = prob;
     params[HatsFinchHelper::kSurveyCycleLengthParam] = cycle_length;
     params[HatsFinchHelper::kSurveyStartDateMsParam] = start_date;
     params[HatsFinchHelper::kResetSurveyCycleParam] = reset_survey;
     params[HatsFinchHelper::kResetAllParam] = reset;
     return params;
   }
 
  private:
   // Must outlive |profile_|.
   content::TestBrowserThreadBundle thread_bundle_;
 
  protected:
   TestingProfile profile_;
 
  private:
   variations::testing::VariationParamsManager params_manager_;
-  base::test::ScopedFeatureList scoped_feature_list_;
 
   DISALLOW_COPY_AND_ASSIGN(HatsFinchHelperTest);
 };
 
 TEST_F(HatsFinchHelperTest, InitFinchSeed_ValidValues) {
   ParamMap params =
       CreateParamMap("1.0", "7", "1475613895337", "false", "false");
   SetFinchSeedParams(params);
 
   HatsFinchHelper hats_finch_helper(&profile_);
@@ skipping 92 matching lines @@
             2 * current_time.ToJsTime());
 
   EXPECT_FALSE(pref_service->GetBoolean(prefs::kHatsDeviceIsSelected));
   EXPECT_NE(pref_service->GetInt64(prefs::kHatsSurveyCycleEndTimestamp),
             initial_timestamp);
   EXPECT_NE(pref_service->GetInt64(prefs::kHatsLastInteractionTimestamp),
             initial_timestamp);
 }
 
 }  // namespace chromeos